Skip to content

chore: Replace tokio sleep with background executor timer #2504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
huacnlee merged 1 commit into from
Jun 24, 2026
Merged

chore: Replace tokio sleep with background executor timer #2504

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions skills/gpui/references/async.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,8 @@ impl MyView {
let _task = cx.spawn(async move |this, cx: &mut AsyncApp| {
// Task automatically cancelled when dropped
loop {
tokio::time::sleep(Duration::from_secs(1)).await;
cx.background_executor().timer(Duration::from_secs(1)).await;

this.update(cx, |state, cx| {
state.tick();
cx.notify();
Expand Down Expand Up @@ -145,7 +146,8 @@ cx.background_spawn(async move {
```rust
cx.spawn(async move |this, cx: &mut AsyncApp| {
loop {
tokio::time::sleep(Duration::from_secs(5)).await;
cx.background_executor().timer(Duration::from_secs(5)).await;

this.update(cx, |state, cx| {
state.tick();
cx.notify();
Expand Down
Loading