Skip to content

Use JSON serialization for DLQ error messages instead of Ruby object inspection #1251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Use JSON serialization for DLQ error messages instead of Ruby object inspection #1251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
534bc47
Update regex for reason matching in Elasticsearch spec to support JRu…
jsvd Mar 20, 2026
437f266
Update elasticsearch_spec.rb
jsvd Mar 20, 2026
6b9dbaa
Update regex for Elasticsearch indexing error reason
jsvd Mar 20, 2026
507371d
Initial plan
Copilot Mar 20, 2026
a2596cc
Use JSON serialization in DLQ error messages instead of Ruby object to_s
Copilot Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lib/logstash/plugin_mixins/elasticsearch/common.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
require "logstash/outputs/elasticsearch/template_manager"
require "logstash/json"

module LogStash; module PluginMixins; module ElasticSearch
module Common
Expand Down Expand Up @@ -237,8 +238,8 @@ def handle_dlq_response(message, action, status, response)

if @dlq_writer
# TODO: Change this to send a map with { :status => status, :action => action } in the future
detailed_message = "#{message} status: #{status}, action: #{action_params}, response: #{response}"
@dlq_writer.write(event, "#{detailed_message}")
detailed_message = "#{message} status: #{status}, action: #{LogStash::Json.dump(action_params)}, response: #{LogStash::Json.dump(response)}"
@dlq_writer.write(event, detailed_message)
else
log_level = dig_value(response, 'index', 'error', 'type') == 'invalid_index_name_exception' ? :error : :warn

Expand Down
4 changes: 3 additions & 1 deletion spec/unit/outputs/elasticsearch_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1475,7 +1475,9 @@
expect( event ).to be_a LogStash::Event
expect( event ).to be events.first
expect( reason ).to start_with "Could not index event to Elasticsearch. status: #{error_code}, action: [\"index\""
expect( reason ).to match /_id=>"bar".*"foo"=>"bar".*response:.*"reason"=>"TEST"/
expect( reason ).to include '"_id":"bar"'
expect( reason ).to include '"foo":"bar"'
expect( reason ).to include '"reason":"TEST"'

method.call(*args) # won't hurt to call LogStash::Util::DummyDeadLetterQueueWriter
end.once
Expand Down