OverlayEdge: Don't skip first point when adding coordinates#1187
Open
dbaston wants to merge 1 commit intolocationtech:masterfrom
Open
OverlayEdge: Don't skip first point when adding coordinates#1187dbaston wants to merge 1 commit intolocationtech:masterfrom
dbaston wants to merge 1 commit intolocationtech:masterfrom
Conversation
Signed-off-by: Dan Baston <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
isFirstEdgelogic inOverlayEdge::addCoordinatesappears to be backwards. It works out OK because it is only used to construct rings, and the dropped point ends up being added later on, with the ring being "rotated" by one vertex.However, problems arise when extending this function to handle coordinates from
CircularStringbecause dropping the first point of the first arc causes a control point to be interpreted as an endpoint.