ENH:add local orbit distortion filter function to sofb device - #1269
Open
Gabrielrezende-asc wants to merge 9 commits into
Open
ENH:add local orbit distortion filter function to sofb device#1269Gabrielrezende-asc wants to merge 9 commits into
Gabrielrezende-asc wants to merge 9 commits into
Conversation
Gabrielrezende-asc
requested review from
anacso17,
fernandohds564 and
xresende
as code owners
August 14, 2026 12:58
fernandohds564
left a comment
fernandohds564
left a comment
Contributor
There was a problem hiding this comment.
very nice, @Gabrielrezende-asc ! I left a comment/suggestion in the code.
Following Fernando suggestions Co-authored-by: fernandohds564 <fernandohds564@gmail.com>
Contributor
Author
Thanks, I just implemented your suggestions. |
fernandohds564
left a comment
fernandohds564
left a comment
Contributor
There was a problem hiding this comment.
Thanks for implementing the suggestions, @Gabrielrezende-asc . I added another comment/suggestion.
Co-authored-by: fernandohds564 <fernandohds564@gmail.com>
Co-authored-by: fernandohds564 <fernandohds564@gmail.com>
fernandohds564
approved these changes
Aug 18, 2026
anacso17
approved these changes
Aug 18, 2026
anacso17
approved these changes
Aug 18, 2026
fernandohds564
approved these changes
Aug 18, 2026
|
|
||
| def filter_local_distortions(corr_idcs, dorb=None, respmat=None): | ||
| """Filters local distortions. | ||
|
|
Contributor
There was a problem hiding this comment.
@Gabrielrezende-asc , could you improve documentation to explain what is the shape of the expected orbit array, in case it is a 2D array and also explaining the shape of the output?
HenriqueWS11
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.