Skip to content

Improve: SI Tune Feedback - Separate planes - #1267

Open
VitorSouzaLNLS wants to merge 10 commits into
dev/enh/si-tune-fbfrom
dev/enh/si-tune-fb-separate-planes
Open

Improve: SI Tune Feedback - Separate planes#1267
VitorSouzaLNLS wants to merge 10 commits into
dev/enh/si-tune-fbfrom
dev/enh/si-tune-fb-separate-planes

Conversation

@VitorSouzaLNLS

Copy link
Copy Markdown
Contributor

Description

This PR updates the SI Tune Feedback system to handle the horizontal and vertical tune planes independently.

Previously, tune sources, PID gains, and maximum tune errors were shared between both planes. This change introduces independent configuration and feedback parameters for the X and Y planes, allowing each plane to use its own tune measurement source and PID controller settings.

Motivation

Separating the tune feedback configuration by plane provides independent control of the horizontal and vertical tunes. This is particularly useful when the two planes require different measurement sources, PID gains, or acceptable tune-error limits.

Changes

  • Add independent tune source selection for the X and Y planes:
    • TuneXSrc-Sel
    • TuneYSrc-Sel
  • Add independent maximum tune error limits:
    • MaxTuneXErr-SP/RB
    • MaxTuneYErr-SP/RB
  • Add independent PID gains for each plane:
    • LoopPIDKpX/Y-SP/RB
    • LoopPIDKiX/Y-SP/RB
    • LoopPIDKdX/Y-SP/RB

@VitorSouzaLNLS VitorSouzaLNLS changed the title Separate planes for tune measurement and correction in the SI Tune Feedback system Improve: SI Tune Feedback - Separate planes Aug 13, 2026
@xresende

xresende commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

@VitorSouzaLNLS , just a reminder: we already added a few PVs of the loop in the archiver appliance. When deploying this PR we should update PVs in the archiver...

@xresende

Copy link
Copy Markdown
Contributor

PV names suggestion (to be discussed):

MaxTuneXErr-SP/RB -> TuneXMaxErr-SP/RB
MaxTuneYErr-SP/RB -> TuneYMaxErr-SP/RB
LoopPIDKpX/Y-SP/RB -> TuneX/YLoopPIDKp-SP/RB
LoopPIDKiX/Y-SP/RB -> TuneX/YLoopPIDKi-SP/RB
LoopPIDKdX/Y-SP/RB -> TuneX/YLoopPIDKd-SP/RB

To me this is a more natural keyword ordering (that, for exmaple, helps filtering PVs more naturally in the archive appliance)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants