Improve: SI Tune Feedback - Separate planes - #1267
Open
VitorSouzaLNLS wants to merge 10 commits into
Open
Conversation
VitorSouzaLNLS
requested review from
anacso17,
fernandohds564 and
xresende
as code owners
August 13, 2026 12:57
…ange to be added on the base branch "dev/enh/si-tune-fb"
Contributor
|
@VitorSouzaLNLS , just a reminder: we already added a few PVs of the loop in the archiver appliance. When deploying this PR we should update PVs in the archiver... |
Contributor
|
PV names suggestion (to be discussed):
To me this is a more natural keyword ordering (that, for exmaple, helps filtering PVs more naturally in the archive appliance) |
Fix tune device "acquisition" typos
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the SI Tune Feedback system to handle the horizontal and vertical tune planes independently.
Previously, tune sources, PID gains, and maximum tune errors were shared between both planes. This change introduces independent configuration and feedback parameters for the X and Y planes, allowing each plane to use its own tune measurement source and PID controller settings.
Motivation
Separating the tune feedback configuration by plane provides independent control of the horizontal and vertical tunes. This is particularly useful when the two planes require different measurement sources, PID gains, or acceptable tune-error limits.
Changes
TuneXSrc-SelTuneYSrc-SelMaxTuneXErr-SP/RBMaxTuneYErr-SP/RBLoopPIDKpX/Y-SP/RBLoopPIDKiX/Y-SP/RBLoopPIDKdX/Y-SP/RB