Skip to content

Fix setup wizard crash on Windows (termios/tty are Unix-only) #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
noahoja-commits wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix setup wizard crash on Windows (termios/tty are Unix-only) #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 15 additions & 8 deletions setup_wizard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,18 +22,11 @@

def capture_hotkey(prompt: str, default: str) -> str:
"""Capture a single keypress from the user."""
import termios
import tty

console.print(f"\n [bold]{prompt}[/bold]")
console.print(f" [dim]Press any key... (default: {default.upper()})[/dim]")

captured = [None]

# Save terminal settings and switch to raw mode (no echo)
fd = sys.stdin.fileno()
old_settings = termios.tcgetattr(fd)

def on_press(key):
try:
if hasattr(key, 'name'):
Expand All @@ -46,12 +39,26 @@ def on_press(key):
captured[0] = default
return False

# On Unix, switch the terminal to raw mode so the keypress isn't echoed.
# Windows has no termios/tty; pynput's listener captures the key without it.
old_settings = None
fd = None
try:
import termios
import tty
fd = sys.stdin.fileno()
old_settings = termios.tcgetattr(fd)
tty.setraw(fd)
except Exception:
old_settings = None # Non-Unix or non-tty stdin: skip raw mode

try:
with keyboard.Listener(on_press=on_press) as listener:
listener.join()
finally:
termios.tcsetattr(fd, termios.TCSADRAIN, old_settings)
if old_settings is not None:
import termios
termios.tcsetattr(fd, termios.TCSADRAIN, old_settings)

result = captured[0] or default
console.print(f" [green]\u2713[/green] Set to [bold cyan]{result.upper()}[/bold cyan]")
Expand Down