Conversation
fixes llvm#706 With the following PRs now merged - llvm/llvm-project#172384 - llvm/llvm-project#175809 - llvm/llvm-project#175245 - llvm/llvm-project#175633 We have a working base to test booleans on both DXC and Clang.
farzonl
force-pushed
the
mat_bool_operator_tests
branch
from
30db7a7 to
adb0358
Compare
bob80905
left a comment
bob80905
left a comment
There was a problem hiding this comment.
Looks mostly good. You might want to document your reasoning for why you chose not to add a thread test for the or operator.
| Data: [ 1, 1, 1, 1, 1, 1 ] | ||
| - Name: AndTrueFalseOut | ||
| Format: Int32 | ||
| FillSize: 24 |
There was a problem hiding this comment.
You might consider setting this data to be non-zero. A nit, but it ensures that the buffer is actually being set to 0, and that the program is actually running.
There was a problem hiding this comment.
I agree that we should ensure the buffers are not zero-initialized
inbelic
left a comment
inbelic
left a comment
There was a problem hiding this comment.
LGTM once Josh's comments are addressed.
The tests do seem to overlap a lot, could we not have the same test coverage with a single 2x2 matrix that has a TT, TF, FT, FF combination?
| Data: [ 1, 1, 1, 1, 1, 1 ] | ||
| - Name: AndTrueFalseOut | ||
| Format: Int32 | ||
| FillSize: 24 |
There was a problem hiding this comment.
I agree that we should ensure the buffers are not zero-initialized
| # Bug https://github.com/llvm/offload-test-suite/issues/704 | ||
| # XFAIL: Clang && Intel && Vulkan | ||
|
|
||
| Bug https://github.com/llvm/offload-test-suite/issues/705 |
There was a problem hiding this comment.
| Bug https://github.com/llvm/offload-test-suite/issues/705 | |
| # Bug https://github.com/llvm/offload-test-suite/issues/705 |
5 participants
fixes #706
With the following PRs now merged
We have a working base to test booleans on both DXC and Clang.