[DO NOT REVIEW] Investigate fma Intel failure#1052
Draft
Conversation
kmpeng
added
the
test-all
farzonl
reviewed
Apr 1, 2026
test/Feature/HLSLLib/fma.test
Outdated
| # last two rows: 2^-26, -(2^-26), 2^-104, -3 | ||
| Results: | ||
| - Result: Result | ||
| Rule: BufferExact |
Member
There was a problem hiding this comment.
try this with the epsilon matcher and see if the issue goes away.
Contributor
Author
There was a problem hiding this comment.
what would be an appropriate epsilon for this? wouldn't BufferFloatULP with a ULP of 1-2 make more sense?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.