Skip to content

Add a new clang-x64-windows-msvc-forward-slashes builder. #746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matts1 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add a new clang-x64-windows-msvc-forward-slashes builder. #746

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions buildbot/osuosl/master/config/builders.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -659,6 +659,17 @@ def collapseRequestsDoxygen(master, builder, req1, req2):
script="clang-windows.py",
depends_on_projects=['llvm', 'clang', 'lld', 'debuginfo-tests'])},

{'name' : 'clang-x64-windows-msvc-forward-slashes',
Copy link
Copy Markdown
Author

@matts1 matts1 Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The consensus in llvm/llvm-project#179865 was that this bot was important enough to run, but not important enough to spend CI resources to run as a pre-merge check.

I have no idea if this is even possible with buildbot, but my ideal scenario would be:

  • Run it on a schedule (eg. 1/day)
  • If a failure occurs, ideally it could bisect the failure to the failing commit and automatically comment on the commit saying that it broke some postsubmit tests.

What would be the recommended run configuration, and where / how can we configure it?

Copy link
Copy Markdown
Author

@matts1 matts1 Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume we want to start with a staging builder. Is that as simple as adding a suffix "-staging"? Or is there no way to add a staging builder, only a staging worker?

Copy link
Copy Markdown
Contributor

@boomanaiden154 boomanaiden154 Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The configuration is the same between the staging and production buildmasters. There are no naming differences for the builders. It just depends upon which buildmaster you connect your worker to (staging vs production).

'tags' : ["clang"],
'workernames' : ['windows-gcebot2'],
Copy link
Copy Markdown
Author

@matts1 matts1 Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reuses an existing worker. I assumed this was fine since the intent was to run this builder infrequently. Please tell me if this isn't the case.

Copy link
Copy Markdown
Contributor

@boomanaiden154 boomanaiden154 Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builders don't run infrequently. They run as often as possible, up to doing a run on every commit. The original suggestion in the PR was to update the configuration of one of these builders, not add a new builder (from what I understand).

Copy link
Copy Markdown
Author

@matts1 matts1 Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can tell, there are mostly only two options for builders to reuse. The clang x64 windows builder, and the clang arm64 windows builder. We could modify an existing builder, though there'd be concerns that the builder would immediately start failing because the tests are not yet passing.

How would people feel about using the clang arm64 windows builder? We appear to have two of them - a 1 stage, and a 2 stage?

Copy link
Copy Markdown
Contributor

@boomanaiden154 boomanaiden154 Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'd have to ping one of the owners of that bot. Ideally the configuration should be green before switching a buldbot over to it.

'builddir': 'clang-x64-windows-msvc-forward-slashes',
'factory' : AnnotatedBuilder.getAnnotatedBuildFactory(
script="clang-windows.py",
extra_args=[
'--extra_cmake_arg=-DLLVM_WINDOWS_PREFER_FORWARD_SLASH=ON',
],
depends_on_projects=['llvm', 'clang', 'lld', 'debuginfo-tests'])},

{'name' : "clang-m68k-linux",
'tags' : ["clang"],
'workernames' : ["debian-akiko-m68k"],
Expand Down
3 changes: 2 additions & 1 deletion zorg/buildbot/builders/annotated/clang-windows.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

def main(argv):
ap = annotated_builder.get_argument_parser()
ap.add_argument('--extra_cmake_arg', nargs='*', default=[])
args = ap.parse_args(argv[1:])

# TODO: Add back debuginfo-tests once it works.
Expand All @@ -19,7 +20,7 @@ def main(argv):
'-DLLVM_ENABLE_PDB=ON',
'-DLLVM_ENABLE_ASSERTIONS=ON',
'-DLLVM_TARGETS_TO_BUILD=all',
]
] + args.extra_cmake_arg
check_targets = [
'check-llvm',
'check-clang',
Expand Down