Fixed the exception twisted.web._newclient.RequestGenerationFailed#720
Merged
Conversation
slydiman
force-pushed
the
fix-createStatus
branch
4 times, most recently
from
1ce3191 to
cc369a2
Compare
Added @defer.inlineCallbacks before def is_wrong_issue to make twisted happy.
slydiman
force-pushed
the
fix-createStatus
branch
from
cc369a2 to
4cca655
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added @defer.inlineCallbacks before def is_wrong_issue to make twisted happy.
And never use
debug=Truein GitHubStatusPush and inherited classes.It will cause unexpected exceptions inside HTTP client service.