Enhance MergeMeshes with mixed field support#1863
Open
BradWhitlock wants to merge 36 commits into
Open
Conversation
…rial-dependent fields
jcs15c
reviewed
May 13, 2026
| template <typename FuncType> | ||
| void dispatchMixedField(conduit::Node &n_matset, conduit::Node &n_field, FuncType &&func) | ||
| { | ||
| axom::bump::views::dispatch_material_field(n_matset, n_field, [&](auto matsetView) { |
Contributor
There was a problem hiding this comment.
Does this require #include "axom/bump/views/dispatch_material_field.hpp" in this file? My local version of this branch won't compile without it, although I'm not sure what's different about my configuration that it doesn't get propagated to here.
Member
Author
There was a problem hiding this comment.
Yes, I'll add that.
Member
Author
|
I converted to Draft because I need to debug some weirdness on GPU platforms. I think I also have some problems with traversing mixed fields in some cases that could merit some design changes. :( |
…its material traversal from a MatsetView::const_iterator and values from trait classes.
BradWhitlock
requested review from
Arlie-Capps,
bmhan12,
jcs15c,
kennyweiss,
publixsubfan and
rhornung67
jcs15c
reviewed
Jun 16, 2026
jcs15c
approved these changes
Jun 16, 2026
jcs15c
left a comment
jcs15c
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me! It works exactly like I needed it to in my original context, so thank you very much for putting this in!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves #1860 by enhancing the
MergeMeshesclasses so they support element-associated mixed fields.