Prevent broken crop when minResolution is unreachable#381
Open
robinbisping wants to merge 1 commit into
Open
Conversation
robinbisping
force-pushed
the
fix-unreachable-min-resolution
branch
from
4b10afd to
ceb399b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relations:
Motivation
The configured
minResolutioncannot always be reached, depending on the image dimensions and configured crop ratio.srcissorsused to render an invalid crop in such cases. Generally, this should be considered a configuration error, but this patch safeguards against it by ignoringminResolutionand locking the zoom at the most zoomed-out state, where the crop covers the largest possible image area.Before:
Screen.Recording.2026-06-01.at.14.37.26.mov
After:
Screen.Recording.2026-06-01.at.14.36.06.mov
Changelog