Skip to content

ffeat: Implement custom RFC 4733 DTMF decoding with End-bit detection #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
usluio wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ffeat: Implement custom RFC 4733 DTMF decoding with End-bit detection #585

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion pkg/sip/inbound.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1350,17 +1350,27 @@ func (c *inboundCall) playAudio(ctx context.Context, frames []msdk.PCM16Sample)
}

func (c *inboundCall) handleDTMF(tone dtmf.Event) {
log := c.log()
log.Infow("DTMF received from phone", "digit", string(tone.Digit), "code", tone.Code, "forwardDTMF", c.forwardDTMF.Load())

if c.forwardDTMF.Load() {
_ = c.lkRoom.SendData(&livekit.SipDTMF{
err := c.lkRoom.SendData(&livekit.SipDTMF{
Code: uint32(tone.Code),
Digit: string([]byte{tone.Digit}),
}, lksdk.WithDataPublishReliable(true))
if err != nil {
log.Warnw("Failed to forward DTMF to room", err, "digit", string(tone.Digit))
} else {
log.Infow("DTMF forwarded to room successfully", "digit", string(tone.Digit))
}
return
}
log.Debugw("DTMF not forwarded (forwardDTMF=false), buffering for PIN", "digit", string(tone.Digit))
// We should have enough buffer here.
select {
case c.dtmf <- tone:
default:
log.Warnw("DTMF buffer full, dropping tone", nil, "digit", string(tone.Digit))
}
}

Expand Down