-
Notifications
You must be signed in to change notification settings - Fork 3k
feat(stt): add speaker diarization support to STT interface and proxy #5283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
russellmartin-livekit
wants to merge
5
commits into
main
Choose a base branch
from
claude/slack-support-diarization-stt-providers-cWpcE
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+50
−0
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
7a50ba7
fix(inference): set STT capabilities.diarization from extra_kwargs
claude f2e936e
feat(inference): enhance STT to identify speaker ID from words
russellmartin-livekit 4eee7ce
feat(types): add speaker_id attribute to TimedString class
russellmartin-livekit f383164
fix(types): change speaker_id type from int to str in TimedString class
russellmartin-livekit f97f729
refactor(inference): streamline speaker_id handling in SpeechData
russellmartin-livekit File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -257,3 +257,31 @@ def test_connect_options_full_custom(self): | |
| assert stt._opts.conn_options.timeout == 60.0 | ||
| assert stt._opts.conn_options.max_retry == 10 | ||
| assert stt._opts.conn_options.retry_interval == 2.0 | ||
|
|
||
|
|
||
| class TestSTTDiarizationCapabilities: | ||
| """Tests for STT diarization capability detection from extra_kwargs.""" | ||
|
|
||
| def test_no_diarization_by_default(self): | ||
| """Without diarization params, capabilities.diarization is False.""" | ||
| stt = _make_stt() | ||
| assert stt.capabilities.diarization is False | ||
|
|
||
| def test_diarization_enabled_with_deepgram_diarize(self): | ||
| """Deepgram's 'diarize' param enables diarization capability.""" | ||
| stt = _make_stt(extra_kwargs={"diarize": True}) | ||
| assert stt.capabilities.diarization is True | ||
|
|
||
| def test_diarization_enabled_with_assemblyai_speaker_labels(self): | ||
| """AssemblyAI's 'speaker_labels' param enables diarization capability.""" | ||
| stt = _make_stt(model="assemblyai/universal-streaming", extra_kwargs={"speaker_labels": True}) | ||
| assert stt.capabilities.diarization is True | ||
|
|
||
| def test_update_options_toggles_diarization(self): | ||
| """update_options can enable and disable diarization capability.""" | ||
| stt = _make_stt() | ||
| assert stt.capabilities.diarization is False | ||
| stt.update_options(extra={"diarize": True}) | ||
| assert stt.capabilities.diarization is True | ||
| stt.update_options(extra={"diarize": False}) | ||
| assert stt.capabilities.diarization is False | ||
|
Comment on lines
+262
to
+287
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Those tests aren't really useful?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yeah its overkill, removed most of them |
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.