Skip to content

refactor(room-io): use protocol TimedString for jsonFormat output#1348

Merged
toubatbrian merged 1 commit intoclaude/jolly-lovelace-cj98Xfrom
claude/remove-unused-protocol-uHVue
Apr 30, 2026
Merged

refactor(room-io): use protocol TimedString for jsonFormat output#1348
toubatbrian merged 1 commit intoclaude/jolly-lovelace-cj98Xfrom
claude/remove-unused-protocol-uHVue

Conversation

@toubatbrian
Copy link
Copy Markdown
Contributor

Replace the inline Record<string, unknown> + JSON.stringify path in ParticipantTranscriptionOutput.encodeJsonChunk with the @livekit/protocol TimedString proto class (added in livekit/protocol#1502). agents-js already depends on @livekit/protocol, so use it directly to mirror the Python implementation's agent_pb.TimedString + MessageToDict serialization. Bumps @livekit/protocol to ^1.45.6 to pick up the TimedString message.

Replace the inline Record<string, unknown> + JSON.stringify path in
ParticipantTranscriptionOutput.encodeJsonChunk with the @livekit/protocol
TimedString proto class (added in livekit/protocol#1502). agents-js already
depends on @livekit/protocol, so use it directly to mirror the Python
implementation's agent_pb.TimedString + MessageToDict serialization. Bumps
@livekit/protocol to ^1.45.6 to pick up the TimedString message.
@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 30, 2026

⚠️ No Changeset found

Latest commit: 806760b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@toubatbrian toubatbrian merged commit 698bc7f into claude/jolly-lovelace-cj98X Apr 30, 2026
0 of 2 checks passed
@toubatbrian toubatbrian deleted the claude/remove-unused-protocol-uHVue branch April 30, 2026 02:57
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants