Add ESI dynamic fragments for product actions and notifications - #103
Open
Codencode wants to merge 1 commit into
Open
Add ESI dynamic fragments for product actions and notifications#103Codencode wants to merge 1 commit into
Codencode wants to merge 1 commit into
Conversation
This was referenced Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for dynamic ESI fragments on the product page, specifically for:
The goal is to keep context-dependent product page sections dynamic even when the product page is served from full-page cache.
This should address the remaining issues reported in: #94
In particular, the problems that were not covered by the already merged PR: #96
Please note that this solution requires two generic theme hooks:
displayDynamicFragmentBeforedisplayDynamicFragmentAfterThese hooks are being proposed for the Hummingbird theme here: PrestaShop/hummingbird#988, if accepted, I will propose the same hooks for the classic theme as well.
Without those hooks in the theme templates, the module cannot wrap the relevant product page fragments before the page output is cached.
@WuhuaChen, what do you think about this approach?