ci: attach provenance and SBOM attestations to the published image - #326
Conversation
β Deploy Preview for web-check ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Correction β I got a fact wrong in this PR, and I would rather flag it myself than let it sit. I wrote that the pushed manifest "carries no provenance or SBOM attestation". That is half wrong, and the wrong half matters. Provenance is already there. For public repositories, The SBOM is genuinely new. That part stands β the same page says "SBOM attestations aren't automatically added to the image", and I also wrote in the caveats that So the honest description of this PR is: it adds an SBOM attestation, and pins the provenance mode explicitly instead of relying on the default. Both are still defensible β an explicit line means the behaviour will not change quietly if the default ever does β but it is a smaller change than my description implied, and you should judge it on that basis rather than on what I originally wrote. Happy to retitle and rewrite the description accordingly, or to close this if the SBOM alone is not worth the diff to you. Either is fine β just say which and I will act on it. Apologies for the inaccuracy. It was caught by a maintainer reviewing the same change on another project, and they were right to. |
lissy93
left a comment
There was a problem hiding this comment.
LGTM, thank you @kobihikri
I'll do a follow-up PR in a moment to add signatures (probably in a similar way I did in Dashy's docker workflow: https://github.com/lissy93/dashy/blob/master/.github/workflows/docker.yml)
Hi, and thanks for web-check.
.github/workflows/docker.ymlpublishes the image, but the pushed manifest carries no provenance or SBOM attestation. Someone pulling it cannot check that it was built by this workflow, from this repository, at that tag.web-check is a tool people self-host to inspect other sites, and the usual reason for self-hosting it rather than using the public instance is not wanting the lookups to go through someone else. That is the same instinct that makes image origin worth being able to check.
The change is two lines on the build step:
BuildKit attaches both to the image manifest, so they travel with the image. No permissions change is needed β nothing has to gain
id-token.The SBOM is arguably the more useful half here: web-check bundles a wide set of lookup and scanning libraries, and
sbom: truemakes that inventory readable from the manifest instead of requiring someone to run the container to find out.Two caveats:
mode=maxrecords build args (provenance: trueis the smaller option), and attestations add an extra manifest to the index, which the registry handles.No SLSA level claimed.
Disclosure: I used AI assistance to help spot this and prepare the change, and I read the workflow myself.