Skip to content

feat(training): small UI fixes#429

Merged
nunoeufrasio merged 3 commits intomainfrom
feat/training-small-ui-fixes
Apr 14, 2026
Merged

feat(training): small UI fixes#429
nunoeufrasio merged 3 commits intomainfrom
feat/training-small-ui-fixes

Conversation

@nunoeufrasio
Copy link
Copy Markdown
Contributor

Summary

  • Rename menu label from "Trainings & Certs" to "Training & Certifications"
  • Add Certification Verification Tool to useful links
  • Move Download button to top-right corner of certification cards
  • Move Download Certificate button to top-right corner of training cards

Test plan

  • Navigate to the sidebar and verify the menu label reads "Training & Certifications"
  • Open the Training & Certifications page and verify the Certification Verification Tool link appears in the Useful Links section
  • In the Certifications tab, verify the Download button appears at the top-right of each card
  • In the Enrolled Trainings tab, verify the Download Certificate button on completed trainings appears at the top-right of each card

@nunoeufrasio nunoeufrasio requested a review from a team as a code owner April 13, 2026 13:06
Copilot AI review requested due to automatic review settings April 13, 2026 13:06
Copy link
Copy Markdown

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0b9ee38a-6ea0-4e64-aeb6-f0ce970438dc

📥 Commits

Reviewing files that changed from the base of the PR and between 883462f and a3f8f85.

📒 Files selected for processing (2)
  • apps/lfx-one/src/app/modules/trainings/components/certification-card/certification-card.component.html
  • apps/lfx-one/src/app/modules/trainings/components/training-card/training-card.component.html
🚧 Files skipped from review as they are similar to previous changes (1)
  • apps/lfx-one/src/app/modules/trainings/components/certification-card/certification-card.component.html

Walkthrough

Updated sidebar label, moved/combined download and continue actions into card top rows and simplified card meta rows for training and certification components, and added a "Certification Verification Tool" link to the trainings dashboard.

Changes

Cohort / File(s) Summary
Sidebar Menu
apps/lfx-one/src/app/layouts/main-layout/main-layout.component.ts
Renamed "My Growth" menu item label from "Trainings & Certs" to "Training & Certifications". Icon and routerLink unchanged.
Certification Card
apps/lfx-one/src/app/modules/trainings/components/certification-card/certification-card.component.html
Moved download button from bottom/meta row into top/name row; top row now aligns Expired badge and conditional Download action; bottom row simplified to meta fields.
Training Card
apps/lfx-one/src/app/modules/trainings/components/training-card/training-card.component.html
Consolidated top-row actions to show either "Continue Learning" (when ongoing) or "Download Certificate" (when downloadUrl() exists); description and date/meta rendered consistently; bottom meta row simplified.
Dashboard Content
apps/lfx-one/src/app/modules/trainings/trainings-dashboard/trainings-dashboard.component.ts
Added a USEFUL_LINKS entry: "Certification Verification Tool" → https://training.linuxfoundation.org/certification/verify/.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main changes: UI refinements to the training module including menu label updates, new useful links, and repositioned download buttons.
Description check ✅ Passed The description is directly related to the changeset, clearly outlining the four main modifications with a comprehensive test plan matching the actual changes made.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/training-small-ui-fixes

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Training & Certifications area with minor UX/content tweaks, including navigation wording, an additional useful link, and repositioned download actions for easier discovery.

Changes:

  • Renames the sidebar menu item to “Training & Certifications”.
  • Adds “Certification Verification Tool” to the Useful links list.
  • Moves certification and completed-training download buttons into the card header (top-right).

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
apps/lfx-one/src/app/modules/trainings/trainings-dashboard/trainings-dashboard.component.ts Adds Certification Verification Tool to the Useful Links data source.
apps/lfx-one/src/app/modules/trainings/components/training-card/training-card.component.html Repositions “Download Certificate” (completed trainings) into the header action area.
apps/lfx-one/src/app/modules/trainings/components/certification-card/certification-card.component.html Repositions the certification “Download” button into the header action area alongside the expired badge.
apps/lfx-one/src/app/layouts/main-layout/main-layout.component.ts Updates sidebar label text to “Training & Certifications”.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 13, 2026

🚀 Deployment Status

Your branch has been deployed to: https://ui-pr-429.dev.v2.cluster.linuxfound.info

Deployment Details:

  • Environment: Development
  • Namespace: ui-pr-429
  • ArgoCD App: ui-pr-429

The deployment will be automatically removed when this PR is closed.

MRashad26
MRashad26 previously approved these changes Apr 13, 2026
mlehotskylf
mlehotskylf previously approved these changes Apr 13, 2026
- rename menu label from "Trainings & Certs" to "Training & Certifications"
- add Certification Verification Tool to useful links
- move Download button to top-right corner of certification cards
- move Download Certificate button to top-right corner of training cards

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Nuno Eufrasio <nunoeufrasio@Mac.lan>
@nunoeufrasio nunoeufrasio merged commit 1910417 into main Apr 14, 2026
11 checks passed
@nunoeufrasio nunoeufrasio deleted the feat/training-small-ui-fixes branch April 14, 2026 17:02
@github-actions
Copy link
Copy Markdown

🧹 Deployment Removed

The deployment for PR #429 has been removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants