upcoming: [UIE-9410] - Create Share Group: Implement the Images select table#13567
upcoming: [UIE-9410] - Create Share Group: Implement the Images select table#13567fabrice-akamai wants to merge 16 commits intolinode:developfrom
Conversation
fabrice-akamai
added
the
Private Image Sharing
fabrice-akamai
changed the title
| shareGroupInfoIcon: 'Linodes Rebuild Images-Share Group info icon', | ||
| }; | ||
|
|
||
| export const IMAGE_SELECT_TABLE_SHARE_GROUP_CREATE_PENDO_IDS = { |
…able in the create share groups page
dwiley-akamai
left a comment
dwiley-akamai
left a comment
There was a problem hiding this comment.
The Create Share Group API requires each image in the payload to have a non-empty description, otherwise it returns a 400 Error code.
Per the API spec, shouldn't that field be optional? If the API isn't treating it as such, we should check with them to see if the spec is inaccurate or if it's an API bug
packages/manager/.changeset/pr-13567-upcoming-features-1775674749388.md
Outdated
Show resolved
Hide resolved
…749388.md Co-authored-by: Dajahi Wiley <[email protected]>
This comment was marked as resolved.
This comment was marked as resolved.
Cloud Manager UI test results🔺 1 failing test on test run #7 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/objectStorage/object-storage.e2e.spec.ts" |
|||||||||||||||||
dwiley-akamai
left a comment
dwiley-akamai
left a comment
There was a problem hiding this comment.
Verification steps ✅
Code review ✅
Approved pending Pendo-related tweaks
| landingHeader: 'Share Groups Create Images-Landing Header', | ||
| label: 'Share Groups Create Images-Label', | ||
| description: 'Share Groups Create Images-Description', | ||
| createButton: 'Share Groups Create Images-Create Button', |
There was a problem hiding this comment.
We usually approximately match the breadcrumb structure, so something like Images Share Groups Create–{etc etc.} seems more accurate.
| <> | ||
| <DocumentTitleSegment segment="Create a Share Group" /> | ||
| <LandingHeader | ||
| data-pendo-id={CREATE_SHARE_GROUP_PENDO_IDS.landingHeader} |
There was a problem hiding this comment.
Does passing this to LandingHeader achieve the desired effect? I don't see it when I inspect.
I think you would have to add a pendoId prop to LandingHeader and pass that down to <DocsLink /> in the component (see the analyticsLabel prop)
3 participants
Description 📝
This PR adds the Images table to the Create Share Group page, enabling unrestricted users to select the images to include in a new share group.
Changes 🔄
List any change(s) relevant to the reviewer.
Scope 🚢
Upon production release, changes in this PR will be visible to:
Preview 📷
Screen.Recording.2026-04-08.at.1.28.31.PM.mov
How to test 🧪
Prerequisites
(How to setup test environment)
Verification steps
(How to verify changes)
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅