Skip to content

fix: [PDI-3249] - Potential fix for login loop on session timeout (option 1) #13564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pmakode-akamai wants to merge 3 commits into from
Closed

fix: [PDI-3249] - Potential fix for login loop on session timeout (option 1) #13564

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4655774
potential fix
pmakode-akamai Apr 3, 2026
8e3b4e2
Merge branch 'develop' into login-issue
pmakode-akamai Apr 7, 2026
465a142
Merge branch 'develop' into pdi-3249-potential-fix-login-issue
pmakode-akamai Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/manager/src/OAuth/oauth.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ function clearNonceAndCodeVerifierFromLocalStorage() {
storage.authentication.codeVerifier.clear();
}

function clearAllAuthDataFromLocalStorage() {
export function clearAllAuthDataFromLocalStorage() {
clearNonceAndCodeVerifierFromLocalStorage();
clearAuthDataFromLocalStorage();
}
Expand Down
11 changes: 7 additions & 4 deletions packages/manager/src/request.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,10 @@ import { AxiosHeaders } from 'axios';
import { ACCESS_TOKEN, API_ROOT, DEFAULT_ERROR_MESSAGE } from 'src/constants';
import { setErrors } from 'src/store/globalErrors/globalErrors.actions';

import { clearAuthDataFromLocalStorage, redirectToLogin } from './OAuth/oauth';
import {
clearAllAuthDataFromLocalStorage,
redirectToLogin,
} from './OAuth/oauth';
import { getEnvLocalStorageOverrides, storage } from './utilities/storage';

import type { ApplicationStore } from './store';
Expand Down Expand Up @@ -33,7 +36,7 @@ export type LinodeError = { errors: APIError[] };
*/
let isRedirectingToLogin = false;

export const handleError = (
export const handleError = async (
error: AxiosError<LinodeError>,
store: ApplicationStore
) => {
Expand All @@ -45,8 +48,8 @@ export const handleError = (
window.location.pathname !== '/oauth/callback'
) {
isRedirectingToLogin = true;
clearAuthDataFromLocalStorage();
redirectToLogin();
clearAllAuthDataFromLocalStorage();
await redirectToLogin();
}

const status: number = error.response?.status ?? 0;
Expand Down
Loading