change: [DPS-41857] - Logs: Add new statuses - deactivating, failed#13551
Open
bbanucha-akamai wants to merge 2 commits intolinode:developfrom
Open
change: [DPS-41857] - Logs: Add new statuses - deactivating, failed#13551bbanucha-akamai wants to merge 2 commits intolinode:developfrom
bbanucha-akamai wants to merge 2 commits intolinode:developfrom
Conversation
bbanucha-akamai
force-pushed
the
feature/DPS-41857-add-failed-and-deactivating-status
branch
from
765d145 to
0c8d1c3
Compare
bbanucha-akamai
requested review from
kagora-akamai,
mduda-akamai and
mikeZuber-akamai
| { | ||
| value: streamStatus.Failed, | ||
| label: 'Failed', | ||
| pendoId: 'Logs Delivery Streams-Status Failed', |
Contributor
There was a problem hiding this comment.
New pendo Ids to be added to: https://docs.google.com/spreadsheets/d/1_0eldFGu6nnzoQ3JP5rHLmtY1SGjgpxLEOT8qgf1Xmw/edit?gid=1479039708#gid=1479039708
| ? `You cannot save changes while the stream status is ${selectedStreamStatus}` | ||
| : undefined, | ||
| [selectedStreamStatus] | ||
| [isStreamStatusBlocking, selectedStreamStatus] |
Contributor
There was a problem hiding this comment.
[selectedStreamStatus] should be enough.
isStreamStatusBlocking depends on selectedStreamStatus change.
Contributor
Author
There was a problem hiding this comment.
It must be included in array, cause both are used in the useMemo.
packages/manager/src/features/Delivery/Streams/StreamActionMenu.tsx
Outdated
Show resolved
Hide resolved
Collaborator
Cloud Manager UI test results🔺 1 failing test on test run #6 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/objectStorage/object-storage.e2e.spec.ts" |
|||||||||||||||||
bbanucha-akamai
requested review from
cliu-akamai
and removed request for
a team
bbanucha-akamai
force-pushed
the
feature/DPS-41857-add-failed-and-deactivating-status
branch
from
b7bf0af to
65e34c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Two new statuses (Delivery Logs Streams status) have been added in the UI: Failed and Deactivating.
It also prevents users from performing edit or activate actions when a stream is in either of these statuses.
Changes 🔄
Scope 🚢
Upon production release, changes in this PR will be visible to:
Some customers (e.g. in Beta or Limited Availability)
Target release date 🗓️
April 2026
Preview 📷
How to test 🧪
packages/manager/src/factories/delivery.ts)Verification steps
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🚩 Using a feature flag to protect the release
📱 Providing mobile support
As an Author, before moving this PR from Draft to Open, I confirmed ✅