TPT-4303: Support alert definition entities and update new fields for creation#781
Merged
yec-akamai merged 4 commits intolinode:devfrom May 1, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for alert-definition scoping/regions and introduces a new list module to retrieve entities associated with an alert definition, alongside updating integration coverage and generated documentation samples.
Changes:
- Extend
monitor_services_alert_definitionto acceptscopeandregionsand pass them through on create. - Add new module
monitor_alert_definition_entities_listplus an integration target and docs for it. - Refresh alert-definition sample responses across doc fragments and module docs (including
scope,regions, andentities).
Reviewed changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/integration/targets/monitor_services_alert_definition/tasks/main.yaml | Adds scope/regions to create flow and asserts returned fields. |
| tests/integration/targets/monitor_alert_definition_entities_list/tasks/main.yaml | New integration target validating the new entities-list module returns a list. |
| requirements.txt | Switches linode_api4 dependency from PyPI range to git @dev. |
| plugins/modules/monitor_services_alert_definition.py | Adds scope/regions params and includes them in create request payload. |
| plugins/modules/monitor_alert_definition_entities_list.py | New list module for alert definition entities (beta endpoint). |
| plugins/module_utils/doc_fragments/alert_definitions_list.py | Updates list sample response to include new fields/shape. |
| plugins/module_utils/doc_fragments/alert_definitions_by_service_type_list.py | Updates by-service-type list sample response to include new fields/shape. |
| plugins/module_utils/doc_fragments/alert_definition_info.py | Updates info sample response to include new fields/shape. |
| plugins/module_utils/doc_fragments/alert_definition_entities_list.py | Adds examples and result samples for the new entities-list module. |
| plugins/module_utils/doc_fragments/alert_definition.py | Updates alert definition sample response to include new fields/shape. |
| docs/modules/monitor_services_alert_definition_list.md | Updates sample response JSON to match current API shape. |
| docs/modules/monitor_services_alert_definition_info.md | Updates sample response JSON to match current API shape. |
| docs/modules/monitor_services_alert_definition_by_service_type_list.md | Updates sample response JSON to match current API shape. |
| docs/modules/monitor_services_alert_definition.md | Documents new scope/regions params and updates sample response JSON. |
| docs/modules/monitor_alert_definition_entities_list.md | Adds generated docs page for the new module. |
| README.md | Adds the new module to the module index table. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
yec-akamai
requested review from
lgarber-akamai and
mawilk90
and removed request for
a team
yec-akamai
changed the title
yec-akamai
changed the title
psnoch-akamai
approved these changes
Apr 30, 2026
psnoch-akamai
left a comment
psnoch-akamai
left a comment
There was a problem hiding this comment.
Looks good to me and test passed locally.
lgarber-akamai
approved these changes
May 1, 2026
Contributor
lgarber-akamai
left a comment
lgarber-akamai
left a comment
There was a problem hiding this comment.
Changes look good and tests are passing on my end, nice work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Add support for alert definition scope and regions. Introduce a new list module to retrieve entities associated with an alert definition.
✔️ How to Test