Repository navigation
[testnet] Keep the project template on an encoding_rs version supporting Rust 1.86 - #6817
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
CI on
testnet_conwayis red sincead6ceee1fb("prepare release of SDK v0.15.23", #6816), inthree jobs that all fail the same way:
local::test_project_newtest_project_publish::storage_service_grpctest_project_publish::scylladb_grpcThese tests build a project generated from
linera-service/template/Cargo.toml.template, which hasno lockfile, so Cargo resolves each dependency to its newest version.
encoding_rs0.8.40(2026-09-07) and 0.8.41 (2026-09-09) raised the minimum Rust version to 1.88, while this branch is
pinned to 1.86.0. The last green run predates 0.8.40 by about four hours. The workspace's own
Cargo.lockstill has 0.8.35, so nothing else is affected.Since the template ships inside the
linerabinary,linera project newalso fails for users ofthe freshly released SDK v0.15.23.
Proposal
Cap
encoding_rsbelow 0.8.40 in the template, next to the other versions pinned for Rust 1.86.0under
TODO(#4742), as in #6707 and #6356.Test Plan
CI, plus a local reproduction: instantiating the template by hand with
linera-sdkas a pathdependency and running the same command the test runs,
cargo build --release --target wasm32-unknown-unknownon Rust 1.86.0.encoding_rsto 0.8.35 and builds cleanly, with no other crate reportingan incompatible minimum Rust version.
Release Plan
This PR targets
testnet_conwaydirectly and should go into the next SDK release from thisbranch.
mainis on Rust 1.95 and is not affected.Links
allocative_derive < 0.3.5#6356: earlier pins of the same kind