Repository navigation
Drive circuit-breaker probes for validator notification streams with a timer #6695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+1,830
−125
Merged
Changes from 10 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
0723f57
Drive circuit-breaker probes for validator notification streams with …
ndr-ds 43b45be
Box the listener update-streams future to keep trait-solver Send chec…
ndr-ds a264550
Merge remote-tracking branch 'upstream/main' into ndr-ds/notification…
ndr-ds 245e3e5
Require an elapsed probe deadline before declaring a validator recove…
ndr-ds 6a6291e
Key circuit-breaker recovery on subscribe having resolved, and arm th…
ndr-ds 0bddf6b
Keep the probe timer armed when an update fails, and pace the retry o…
ndr-ds 042d829
Narrow retry_update_deadline back to private now that no test calls it
ndr-ds bb2ee4c
Count a healthy validator's subscribes, and correct three mutation cl…
ndr-ds cefd48d
Cover the in-loop retry arming, and drop three dead constructs
ndr-ds e390115
Say what the subscribed flag actually separates
ndr-ds 1f5be8c
Key stream health on serving rather than subscribing, and arm every l…
ndr-ds 97e1eee
Report a recovery only for a breaker that actually tripped
ndr-ds d190457
Charge a stream's first failure at the configured interval, not double
ndr-ds a8ec5ec
Pin the backoff factor exactly instead of bounding it on one side
ndr-ds 25661e5
Bound probe deadlines on both sides, and cover the per-validator spread
ndr-ds b236b0d
Cover the retry-deadline clear and the escalation cap
ndr-ds 30f9a7e
Assert the recovery barrier instead of discarding it
ndr-ds bcb3a88
Sample the clock after the committee read, and make recovery symmetri…
ndr-ds 7c82cdb
Re-arm an elapsed deadline for a stream that is serving but not yet h…
ndr-ds 72994cd
Pin the re-arm instant, and assert the empty-map precondition
ndr-ds 6e71c22
Elapse the briefly-serving fixture by a real margin
ndr-ds File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MaybeSendBoxFuture<'a, T>isfutures::future::BoxFuture<'a, T>/LocalBoxFuture<'a, T>spelled out, andchain_worker/export.rs:1846already uses those directly with the same cfg split — so the crate still holds two spellings of one policy. A cfg'd re-export keeps the single-source-of-truth win without a second definition:Also,
ReceiveSenderCertificateFuture(client/mod.rs:394-397) is still the same cfg pair written out by hand, in a file this PR already touches for exactly this conversion.