fix(pd): correct DeepSeek V4 layerwise cache handoff#660
Draft
lucifer1004 wants to merge 2 commits into
Draft
Conversation
Signed-off-by: Zihua Wu <13583761+lucifer1004@users.noreply.github.com>
Signed-off-by: Zihua Wu <13583761+lucifer1004@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
DeepSeek V4 stores SWA, compressed KV, compressor state, and indexer state in independently paged cache groups. PD previously applied the legacy KV page indices to every contiguous buffer, so a Mooncake transfer could succeed while copying data between the wrong physical pages.
The DeepSeek V4 attention path also bypassed the common layerwise cache-readiness publication used by PD transfers.
Changes
Compatibility
Ungrouped cache pools retain their existing transfer behavior. Grouped-cache transfers require both peers to run the updated code; missing grouped metadata fails explicitly instead of copying incorrect pages.
This PR does not restore or enable
mooncake_asyncexecutor wiring. Current executors continue to select the synchronous Mooncake managers.Validation
prek -C tokenspeed run --all-filesThe model qualification used the SM120 enablement stack from #648 plus this PD patch; those kernel changes are intentionally excluded from this PR.