perf(multimodal): optimize SHM input transport#610
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1d749e519b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: yechank-nvidia <161688079+yechank-nvidia@users.noreply.github.com>
Signed-off-by: yechank-nvidia <161688079+yechank-nvidia@users.noreply.github.com>
Signed-off-by: yechank-nvidia <161688079+yechank-nvidia@users.noreply.github.com>
Signed-off-by: yechank-nvidia <161688079+yechank-nvidia@users.noreply.github.com>
Signed-off-by: yechank-nvidia <161688079+yechank-nvidia@users.noreply.github.com>
Signed-off-by: yechank-nvidia <161688079+yechank-nvidia@users.noreply.github.com>
1d749e5 to
7afff11
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7afff1105d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "max_num_seqs": server_args.max_num_seqs, | ||
| "chunked_prefill_size": server_args.chunked_prefill_size, | ||
| "max_model_len": event_loop.model_config.context_len, | ||
| "multimodal_encoder_dtype": event_loop.multimodal_encoder_dtype, |
There was a problem hiding this comment.
Report encoder dtype from encode workers
When server_args.disaggregation_mode == "encode", run_event_loop returns through run_encode_loop before this ready payload is sent, and the encode loop’s own ready dict still only includes the token/sequence fields. In that encode-worker deployment, get_server_info() therefore has no multimodal_encoder_dtype, so SMG cannot serialize multimodal tensors in the destination vision dtype for the path that actually loads only the vision tower; mirror this field in the encode-loop ready message as well.
Useful? React with 👍 / 👎.
Summary
Test Plan
pytest -q test/runtime/test_multimodal_encoder_dtype.py test/runtime/test_multimodal_shm_transport.py test/runtime/test_multimodal_tp_broadcast.pypre-commit run --all-files