fix: share forward pass / loss in DFlash / DSpark#134
Merged
Conversation
Signed-off-by: Doğaç Eldenk <dogacel@gmail.com>
Signed-off-by: Doğaç Eldenk <dogacel@gmail.com>
Signed-off-by: Doğaç Eldenk <dogacel@gmail.com>
yubofredwang
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
L1 loss (Same as TV) 0.5, CE loss 0.5 test run on 500 samples:

Also trained some internal checkpoints using 0.5 L1 / 0.5 CE loss and they slightly outperform CE only.
For HF exporting, I have re-exported existing DSpark endpoint (huggingface.co/Dogacel/Qwen3-8B-DSpark) and run,
On the vllm branch: (https://github.com/Dogacel/vllm/tree/dspark-local).
It got ~2.3 acceptance length on SPEED-bench.
Future Work: Potentially moving D-PACE in DSpark's CE objective to get better acceptance, however the anchoring offset is defined differently in DSpark and DFlash, need to look closer.