Skip to content

switchrpc: wire MacService and NetworkDir in config setup #10737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yyforyongyu merged 1 commit into from
Apr 21, 2026
+7 −0
Merged

switchrpc: wire MacService and NetworkDir in config setup #10737

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions subrpcserver_config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,6 +321,13 @@ func (s *subRPCServerConfigs) PopulateDependencies(cfg *Config,
case *switchrpc.Config:
subCfgValue := extractReflectValue(subCfg)

subCfgValue.FieldByName("NetworkDir").Set(
reflect.ValueOf(networkDir),
)
subCfgValue.FieldByName("MacService").Set(
reflect.ValueOf(macService),
)
Comment on lines +324 to +329
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While this is consistent with the rest of the function, using reflection with FieldByName is brittle and can lead to runtime panics if the field names in the switchrpc.Config struct are ever changed.

Since the subCfg variable is already typed as *switchrpc.Config, you can set the fields directly for better type safety and readability.

This would be a good refactoring to apply to the other cases in this function as well.

            subCfg.NetworkDir = networkDir
            subCfg.MacService = macService


subCfgValue.FieldByName("HtlcDispatcher").Set(
reflect.ValueOf(htlcSwitch),
)
Expand Down
Loading