itest+lntest: harden sweep and watchtower flakes#10715
itest+lntest: harden sweep and watchtower flakes#10715yyforyongyu merged 2 commits intolightningnetwork:masterfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses intermittent test failures in the integration test suite. By introducing more deterministic synchronization points for channel states and implementing a robust polling mechanism for mempool transaction retrieval, the changes harden the test environment against race conditions and transient state inconsistencies. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
8b19cdd to
409f366
Compare
There was a problem hiding this comment.
Code Review
This pull request improves the reliability of integration tests by ensuring channel links are active before sending payments and by adding a retry mechanism to GetNumTxsFromMempool to handle RBF-replaced transactions. A minor formatting issue was identified in lntest/miner/miner.go where a newline is needed to separate logical stanzas according to the style guide.
409f366 to
d9c7c81
Compare
|
@yyforyongyu, remember to re-request review from reviewers when ready |
Fix the two flakes,
and