tapdb: make mssmt node inserts idempotent#2118
Conversation
Add ON CONFLICT (hash_key, namespace) DO NOTHING to InsertBranch, InsertLeaf, and InsertCompactedLeaf. In a Merkle tree, identical hashes guarantee identical content, so ignoring duplicates is correct. This fixes UNIQUE constraint violations when tree operations produce nodes whose hashes already exist in the table. Fixes lightninglabs#2116.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces idempotency to the MSSMT node insertion process by handling potential unique constraint conflicts gracefully. By ignoring duplicate entries for existing hash keys within the same namespace, the system ensures stability during tree operations that might otherwise trigger errors when encountering pre-existing nodes. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the MSSMT node insertion queries (InsertBranch, InsertLeaf, and InsertCompactedLeaf) to include an ON CONFLICT (hash_key, namespace) DO NOTHING clause. This change ensures that duplicate insertions do not trigger errors, effectively making the insertion operations idempotent. I have no further feedback to provide.
2 participants
Fixes #2116.
Add ON CONFLICT (hash_key, namespace) DO NOTHING to InsertBranch, InsertLeaf, and InsertCompactedLeaf. In a Merkle tree, identical hashes guarantee identical content, so ignoring duplicates is correct. This fixes UNIQUE constraint violations when tree operations produce nodes whose hashes already exist in the table.