Skip to content

go.mod: bump pool to v0.7.0-beta#1313

Merged
ViktorT-11 merged 2 commits into
masterfrom
bump-pool-v0.7.0-beta
May 21, 2026
Merged

go.mod: bump pool to v0.7.0-beta#1313
ViktorT-11 merged 2 commits into
masterfrom
bump-pool-v0.7.0-beta

Conversation

@Roasbeef
Copy link
Copy Markdown
Member

@Roasbeef Roasbeef commented May 20, 2026

In this PR, we bump the embedded pool dependency up to v0.7.0-beta. The main motivation is to pull in two reliability fixes around the auctioneer subscription path that were causing the order subscribe stream to silently die after extended runtime.

The first fix is the EOF handling in the subscribe stream (lightninglabs/pool#518). Before, an EOF from the auctioneer would leave the client in a state where the gRPC connection looked healthy, but no further order updates would actually arrive. We now treat EOF the same as any other transient stream error and trigger a reconnect rather than swallowing it. The second piece (also lightninglabs/pool#518) adds jittered backoff on the reconnect path, which avoids the thundering-herd scenario where every connected trader retries at the same instant after the auctioneer comes back up from a brief restart.

The release also pulls in the stream handling fix in consumePendingOpenChannels (lightninglabs/pool#507) so we don't get stuck on pending channel finalization, plus the usual round of transitive dependency bumps (go-viper/mapstructure/v2, opencontainers/runc, golang-jwt/jwt/v4, golang.org/x/net).

The diff itself is minimal: just go.mod/go.sum and a one-bullet entry under ### Pool in the upcoming 0.17.0 release notes.

Test plan

  • go build ./... passes on the main lit module.
  • CI passes.

Updates the embedded pool dependency to v0.7.0-beta, which brings in the
auctioneer EOF reconnect and jittered backoff fixes (#518) and the
pending-open-channel stream handling fix (#507), along with the usual
round of transitive dependency bumps.
@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a routine dependency update for the pool module to version v0.7.0-beta. This upgrade introduces several stability improvements, including better reconnection handling for auctioneer streams and refined logic for managing pending channels, while also updating various transitive dependencies.

Highlights

  • Dependency Update: Updated the pool dependency from v0.6.6-beta to v0.7.0-beta.
  • Functional Improvements: The update includes fixes for auctioneer stream reconnection, jittered backoff logic, and stream handling in funding processes.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the github.com/lightninglabs/pool dependency from version v0.6.6-beta to v0.7.0-beta in both go.mod and go.sum. I have no feedback to provide as there are no review comments.

Copy link
Copy Markdown
Contributor

@bitromortac bitromortac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

Copy link
Copy Markdown
Contributor

@ViktorT-11 ViktorT-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉!

@ViktorT-11 ViktorT-11 merged commit 00a2bc8 into master May 21, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants