Skip to content

Introduce recurrence TLV support for BOLT12 messages #4614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shaavan wants to merge 6 commits into
base: main
Choose a base branch
from

[test] Cover invoice recurrence parsing

1af9185
Select commit
Loading
Failed to load commit list.
Open

Introduce recurrence TLV support for BOLT12 messages #4614

[test] Cover invoice recurrence parsing
1af9185
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 15, 2026 in 0s

86.43% (-0.66%) compared to 2313bd5

View this Pull Request on Codecov

86.43% (-0.66%) compared to 2313bd5

Details

Codecov Report

❌ Patch coverage is 90.31505% with 83 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.43%. Comparing base (2313bd5) to head (1af9185).
⚠️ Report is 109 commits behind head on main.

Files with missing lines Patch % Lines
lightning/src/offers/invoice_request.rs 86.41% 27 Missing and 9 partials ⚠️
lightning/src/offers/offer.rs 88.33% 17 Missing and 16 partials ⚠️
lightning/src/offers/invoice.rs 95.95% 5 Missing and 2 partials ⚠️
lightning/src/offers/refund.rs 93.84% 3 Missing and 1 partial ⚠️
lightning/src/offers/static_invoice.rs 95.77% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4614      +/-   ##
==========================================
- Coverage   87.08%   86.43%   -0.66%     
==========================================
  Files         161      158       -3     
  Lines      109255   110131     +876     
  Branches   109255   110131     +876     
==========================================
+ Hits        95147    95188      +41     
- Misses      11627    12366     +739     
- Partials     2481     2577      +96

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov