Repository navigation

Merge packages, introduce skins, update tooling - #400

Open

alx-khramov wants to merge 50 commits into

feature/si-1647-merge-packages

Open

Merge packages, introduce skins, update tooling#400
alx-khramov wants to merge 50 commits into
developfrom
feature/si-1647-merge-packages

alx-khramov commented Oct 13, 2026

Contributor

Resolves SI-993, SI-1005, SI-990, SI-1647

This PR prepares Reef Knot v9 by separating wallet connection behavior from its UI. Applications can use a ready-made UI skin, replace individual views, or build a custom interface using the public headless API.

Consolidates providers, configuration, wallet catalogs and connection logic into reef-knot, removing its dependencies on Lido UI, styled-components and CSS.
Adds @reef-knot/ui-lido-legacy for the existing appearance and @reef-knot/ui-lido for Lido App UI.
Exposes shared headless hooks for wallet discovery, Terms, connection, EIP-6963 and Ledger, with replaceable modal components.
Introduces useConnectionFlow().startConnection() and deprecates useConnect().connect().
Updates demo-react to demonstrate Legacy, Lido App UI and Custom interfaces using one provider stack.
Improves connection error screens and picker UX, prevents stale connection errors after cancellation, and preserves the Ledger accounts screen during connector handoff.
Updates the build and lint tooling, standardizes package type checks on TypeScript 7, and adds migration guides for 0.x → latest and 8.x → 9.

BREAKING CHANGE: Removes reef-knot/* subpath imports and root namespace exports. Visual APIs move to the UI skin packages. Removes the legacy web3-react layer, including useWeb3 and useSupportedChains, as well as buttonComponentsByConnectorId, wallet-specific Connect* components and linkDontHaveWallet. Wallet adapter types move from @reef-knot/types to @reef-knot/wallets-helpers.
Validation: yarn check-packages passes, covering TypeScript, lint and tests. Both UI skins share scenario tests, with additional regression coverage for cancelled connections, Ledger transport handoff and icon stability.

alx-khramov added 14 commits

October 12, 2026 23:57


          feat: merge packages, remove legacy web3-react package

Signed-off-by: Alexander K <alexander.k@lido.fi>


          feat: introduce headless API and separate Lido UI skins

f34364b

Extract wallet connection logic into public headless hooks.
Add legacy and Lido App UI skins with replaceable view components.
Introduce useConnectionFlow and deprecate useConnect.

BREAKING CHANGE: Visual exports move from reef-knot to
@reef-knot/ui-lido-legacy and @reef-knot/ui-lido.
Remove buttonComponentsByConnectorId and wallet-specific Connect*
components; use components overrides or headless hooks instead.

Signed-off-by: Alexander K <alexander.k@lido.fi>


          feat(ledger-connector): use bundler module resolution

867a947


          feat(ui): improve wallet connection errors and picker UX

a3631ea

Signed-off-by: Alexander K <alexander.k@lido.fi>


          chore(demo-react): remove holesky

d055e2e

Signed-off-by: Alexander K <alexander.k@lido.fi>


          chore: update eslint to v10

6c570d5

Signed-off-by: Alexander K <alexander.k@lido.fi>


          chore: use typescript v7, update tsdown

bcbc5a9

Signed-off-by: Alexander K <alexander.k@lido.fi>


          fix(ui-lido): inherit page theme colors in modal

07f398b

Signed-off-by: Alexander K <alexander.k@lido.fi>


          docs(migration): add clarifications

Signed-off-by: Alexander K <alexander.k@lido.fi>


          fix(headless): ignore stale connection rejections

0a2e404

Signed-off-by: Alexander K <alexander.k@lido.fi>


          fix(ledger): preserve accounts screen during handoff

31210f1

Signed-off-by: Alexander K <alexander.k@lido.fi>


          fix(exports): add default entry points for packages

bcae9a6

Signed-off-by: Alexander K <alexander.k@lido.fi>


          chore: standardize type checks

ca219a4

Signed-off-by: Alexander K <alexander.k@lido.fi>


          fix(ui-lido-legacy): preserve wallet icons across renders

e00837e

Signed-off-by: Alexander K <alexander.k@lido.fi>

alx-khramov self-assigned this

alx-khramov requested a review from a team as a code owner

October 13, 2026 10:11

alx-khramov added 14 commits

October 13, 2026 14:30


          chore(ui-lido): constrain supported UI kit versions

e6e78bf

Signed-off-by: Alexander K <alexander.k@lido.fi>


          refactor(ui-lido): use skin-owned dialog markup

99a0047

Signed-off-by: Alexander K <alexander.k@lido.fi>


          fix: various minor fixes

c92e338

Signed-off-by: Alexander K <alexander.k@lido.fi>


          build(ui-lido): watch copied assets

5402c3c

Use native copy entries so styles and assets are watched, including files outside the import graph.

Signed-off-by: Alexander K <alexander.k@lido.fi>


          fix(ledger): enforce configured chain for transactions

3a11f99

Reject mismatched chain IDs before signing or accessing the device.

Signed-off-by: Alexander K <alexander.k@lido.fi>


          fix(headless): await old wallet disconnect before connecting a new one

d125dd3

Wallet replacement used to call disconnect() without waiting for it, so
wagmi could write recentConnectorId after the new connection had already
saved its own keys.

Signed-off-by: Alexander K <alexander.k@lido.fi>


          fix(wallets-helpers): key connector cache by WalletConnect config

b29d691

Signed-off-by: Alexander K <alexander.k@lido.fi>


          fix(reef-knot): match saved wallet to recent connector

6bbd3eb

Signed-off-by: Alexander K <alexander.k@lido.fi>


          refactor(connection): clarify modal state ref usage

b1e18de

Signed-off-by: Alexander K <alexander.k@lido.fi>


          refactor(walletconnect): remove URI-based connection flow

84e63a2

Signed-off-by: Alexander K <alexander.k@lido.fi>


          fix(core-react): disconnect all retained wallets

b68d1d4

Prevent earlier connections from becoming active again, and clear reconnect storage even when a wallet fails to disconnect.

Signed-off-by: Alexander K <alexander.k@lido.fi>


          fix(wallets): wait for EIP-6963 providers on reconnect

953bec5

Prevent injected connectors from falling back to another wallet’s
window.ethereum, and allow auto-reconnect to catch late announcements.

Signed-off-by: Alexander K <alexander.k@lido.fi>


          fix(okx): encode the full page URL in deeplinks

30c6e47

Signed-off-by: Alexander K <alexander.k@lido.fi>


          fix(ui-lido-legacy): always unmount exited transition overlays

be2422d

Keep closed overlays from blocking clicks, focus, and scroll, even when untyped callers pass removed transition options.

Signed-off-by: Alexander K <alexander.k@lido.fi>

alx-khramov added 2 commits

October 16, 2026 21:05


          feat(demo-react): add EIP-712 wallet signing test

e72dece

Signed-off-by: Alexander K <alexander.k@lido.fi>


          fix(reef-knot): restore wallets from saved wallet IDs

1c8da4a

Store wallet IDs directly and verify both saved keys before reconnecting,
including after waiting for late EIP-6963 provider announcements.

Signed-off-by: Alexander K <alexander.k@lido.fi>

Jeday previously approved these changes

View reviewed changes

alx-khramov added 2 commits

October 19, 2026 20:59


          fix(reef-knot): skip auto-reconnect during manual connection

bdb20cc

Avoids interfering with a manual connection already in progress.

Signed-off-by: Alexander K <alexander.k@lido.fi>


          fix(wallets-helpers): resolve late EIP-6963 providers

fa67e39

Look up providers on each request so wallets announced after target creation are available.

Signed-off-by: Alexander K <alexander.k@lido.fi>

alx-khramov dismissed Jeday’s stale review via

fa67e39

October 19, 2026 18:21

alx-khramov temporarily deployed to preview

October 19, 2026 18:27

— with

GitHub Actions Inactive

alx-khramov requested a review from Jeday

October 19, 2026 18:29

Jeday previously approved these changes

View reviewed changes

alx-khramov added 3 commits

October 22, 2026 19:03


          chore(playwright-tests): ignore local environment secrets

0811ae7

Signed-off-by: Alexander K <alexander.k@lido.fi>


          fix(reef-knot): handle wallet rejection errors safely

9a1d1a6

Suppress user-rejection errors and show readable fallback messages for malformed wallet errors.

Signed-off-by: Alexander K <alexander.k@lido.fi>


          fix(ui): clarify connection error dismissal

Show Back in the header and make Close dismiss all connection screens.
Keep rejected wallet requests in the picker without displaying an error.

Signed-off-by: Alexander K <alexander.k@lido.fi>

alx-khramov dismissed Jeday’s stale review via

October 22, 2026 19:09

alx-khramov added 2 commits

October 23, 2026 13:05


          fix(reef-knot): center Ledger views in modal

cd84868

Let Ledger views control their own width to prevent the container clamp from shifting them off center.

Signed-off-by: Alexander K <alexander.k@lido.fi>


          fix(reef-knot): clarify pending wallet requests

ab1b2da

Replace technical wallet errors with guidance to approve or reject the
request already open in the wallet.

Signed-off-by: Alexander K <alexander.k@lido.fi>

alx-khramov temporarily deployed to preview

October 23, 2026 10:23

— with

GitHub Actions Inactive

alx-khramov added 4 commits

October 29, 2026 20:24


          fix(reef-knot): prevent unsafe wallet errors from reaching users

5e8ace4

Signed-off-by: Alexander K <alexander.k@lido.fi>


          feat(ui-lido): improve wallet picker layout and controls

42a5e0f

Signed-off-by: Alexander K <alexander.k@lido.fi>


          fix(ui-lido): improve requirements screens and account loading

b290a70

Signed-off-by: Alexander K <alexander.k@lido.fi>


          fix(ui-lido): highlight connecting wallet

046dd67

Signed-off-by: Alexander K <alexander.k@lido.fi>

alx-khramov temporarily deployed to preview

November 3, 2026 22:56

— with

GitHub Actions Inactive

alx-khramov added 3 commits

November 5, 2026 11:23


          style(ui-lido): set description font weight to regular

abed09b

Signed-off-by: Alexander K <alexander.k@lido.fi>


          feat(modal): add back navigation and connected results

2691ada

Separate returning to the previous screen from closing the entire modal flow, and clarify connection outcomes with the `connected` result field.

Signed-off-by: Alexander K <alexander.k@lido.fi>


          fix(modal): prevent page scrolling on touch devices

a63ec45

Pin and restore the page scroll position on touch devices, and contain
overscroll within modal content.

Signed-off-by: Alexander K <alexander.k@lido.fi>

alx-khramov had a problem deploying to preview

November 5, 2026 09:22

— with

GitHub Actions Failure


          test(reef-knot): clarify connection promise names

9e05d8c

Signed-off-by: Alexander K <alexander.k@lido.fi>

alx-khramov temporarily deployed to preview

November 5, 2026 09:38

— with

GitHub Actions Inactive

alx-khramov added 2 commits

November 5, 2026 15:38


          fix(headless): update generic connection error message

fe29f7f

Signed-off-by: Alexander K <alexander.k@lido.fi>


          fix(reef-knot): detect closed wallet modals as rejection

2d26ba1

Signed-off-by: Alexander K <alexander.k@lido.fi>

alx-khramov deployed to preview

November 5, 2026 12:44

— with

GitHub Actions

View deployment

This branch was successfully deployed

1 active deployment

preview — 2d26ba18 Deployed Nov 5, 2026 by alx-khramov via check-all #38

View deployment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet