Skip to content

chore(info): savestate_features 2 -> 3, with the test that backs it #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoeMatt merged 3 commits into from
Aug 6, 2026
Merged

chore(info): savestate_features 2 -> 3, with the test that backs it #327

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
01c86bd
chore(info): savestate_features 2 -> 3, with the test that backs it
JoeMatt Aug 6, 2026
115b8ac
test(runahead): record what the audio-determinism hunt ruled out
JoeMatt Aug 6, 2026
6fff8e7
fix(dac): serialize the I2S registers — they were in no saved region
JoeMatt Aug 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 27 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1355,7 +1355,8 @@ test/heap_search: test/heap_search.c
tools: test/dump_pc test/heap_search test/test_cd_boot
endif

.PHONY: clean test lint coverage benchmark acid dsp-diag frame-timing cue2cdi
.PHONY: clean test lint coverage benchmark acid dsp-diag frame-timing cue2cdi \
runahead-determinism
endif

lint:
Expand Down Expand Up @@ -1456,6 +1457,31 @@ frame-timing:
$(if $(filter Linux,$(shell uname -s)),-ldl -lrt) -lm
./test/tools/test_frame_timing ./$(TARGET) "$(FRAME_TIMING_ROM)" $(FRAME_TIMING_FLAGS)

# `make runahead-determinism` -- Save-state determinism check. Saves a state,
# replays the same frames after retro_unserialize, and asserts the video and
# audio come back identical. This is the evidence behind
# `savestate_features = 3` in dist/info/, and behind reporting zero
# serialization quirks: run-ahead, rewind and netplay all assume a state is a
# complete snapshot.
#
# NOT part of `make test`: one assertion (audio_replay_identical) is a known
Comment on lines +1485 to +1491
# failure — a single frame of ~0.05% RMS drift on the first rollback. See the
# tool header for the full measurement and what has already been ruled out.
#
# Usage:
# make runahead-determinism RUNAHEAD_ROM="path/to/game.j64"
# make runahead-determinism RUNAHEAD_ROM="path/to/game.j64" RUNAHEAD_FLAGS="--warmup 600 --frames 300"
RUNAHEAD_ROM ?= test/roms/yarc.j64
RUNAHEAD_FLAGS ?=
runahead-determinism:
$(MAKE) TEST_EXPORTS=1 -j$(shell getconf _NPROCESSORS_ONLN 2>/dev/null || echo 4)
$(CC) -O2 -Wall -std=c99 $(INCFLAGS) \
-o test/tools/test_runahead_determinism \
test/tools/test_runahead_determinism.c \
test/harness/harness.c \
$(if $(filter Linux,$(shell uname -s)),-ldl -lrt) -lm
./test/tools/test_runahead_determinism ./$(TARGET) "$(RUNAHEAD_ROM)" $(RUNAHEAD_FLAGS)

# Automated visual + audio verification for CD titles: frame-motion timeline,
# audio RMS, periodic screenshots (PPM). See the tool header for usage.
# make cd-visual CD_VISUAL_DISC="test/roms/private/Title/Title.cue" \
Expand Down
2 changes: 1 addition & 1 deletion dist/info/virtualjaguar_libretro.info
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ systemid = "atari_jaguar"
supports_no_game = "false"
database = "Atari - Jaguar"
savestate = "true"
savestate_features = "2"
savestate_features = "3"
cheats = "true"
input_descriptors = "true"
memory_descriptors = "true"
Expand Down
Loading
Loading