Skip to content

fix confirmed spender height lookup #806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evoskuil merged 1 commit into from
Jun 3, 2026
Merged

fix confirmed spender height lookup #806

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions include/bitcoin/database/impl/query/consensus/consensus_strong.ipp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,9 @@ height_link CLASS::find_strong_spender_height(
size_t out{};
for (const auto& in: to_spenders(point))
if (const auto tx = to_input_tx(in); get_tx_height(out, tx))
break;
return { system::possible_narrow_cast<height_link::integer>(out) };

return { system::possible_narrow_cast<height_link::integer>(out) };
return {};
Comment thread
evoskuil marked this conversation as resolved.
}

// find_strong (block)
Expand All @@ -84,7 +84,7 @@ TEMPLATE
header_link CLASS::find_strong(const tx_link& link) const NOEXCEPT
{
// Shortcuircuit hash-based search by testing self.
if (const auto fk = to_block(link); !link.is_terminal())
if (const auto fk = to_block(link); !fk.is_terminal())
return fk;

return find_strong(get_tx_key(link));
Expand Down
83 changes: 83 additions & 0 deletions test/query/confirmed.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,89 @@ BOOST_AUTO_TEST_CASE(query_confirmed__is_confirmed_tx__confirm__expected)
BOOST_REQUIRE(query.is_confirmed_tx(2));
}

BOOST_AUTO_TEST_CASE(query_confirmed__find_strong__unconfirmed_duplicate__expected)
{
settings settings{};
settings.path = TEST_DIRECTORY;
test::chunk_store store{ settings };
test::query_accessor query{ store };
BOOST_REQUIRE(!store.create(test::events_handler));
BOOST_REQUIRE(query.initialize(test::genesis));
BOOST_REQUIRE(query.set(test::block1a, context{ 0, 1, 0 }, false, false));
BOOST_REQUIRE(query.set_strong(1));

BOOST_REQUIRE(query.set(test::tx4));
const auto unconfirmed = query.to_tx(test::tx4.hash(false));

BOOST_REQUIRE(query.set(test::block_spend_1a, context{ 0, 2, 0 }, false, false));
BOOST_REQUIRE(query.set_strong(2));

BOOST_REQUIRE_EQUAL(query.find_strong(unconfirmed),
query.to_header(test::block_spend_1a.hash()));
}

BOOST_AUTO_TEST_CASE(query_confirmed__find_strong_spender_height__unspent__terminal)
{
settings settings{};
settings.path = TEST_DIRECTORY;
test::chunk_store store{ settings };
test::query_accessor query{ store };
BOOST_REQUIRE(!store.create(test::events_handler));
BOOST_REQUIRE(query.initialize(test::genesis));
BOOST_REQUIRE(query.set(test::block1a, context{ 0, 1, 0 }, false, false));
BOOST_REQUIRE(query.set_strong(1));

const system::chain::point point
{
test::block1a.transactions_ptr()->front()->hash(false), 0
};

BOOST_REQUIRE(query.find_strong_spender_height(point).is_terminal());
}

BOOST_AUTO_TEST_CASE(query_confirmed__find_strong_spender_height__unconfirmed__terminal)
{
settings settings{};
settings.path = TEST_DIRECTORY;
test::chunk_store store{ settings };
test::query_accessor query{ store };
BOOST_REQUIRE(!store.create(test::events_handler));
BOOST_REQUIRE(query.initialize(test::genesis));
BOOST_REQUIRE(query.set(test::block1a, context{ 0, 1, 0 }, false, false));
BOOST_REQUIRE(query.set_strong(1));
BOOST_REQUIRE(query.set(test::tx5));

const system::chain::point point
{
test::block1a.transactions_ptr()->front()->hash(false), 0
};

BOOST_REQUIRE(query.find_strong_spender_height(point).is_terminal());
}

BOOST_AUTO_TEST_CASE(query_confirmed__find_strong_spender_height__confirmed__expected)
{
settings settings{};
settings.path = TEST_DIRECTORY;
test::chunk_store store{ settings };
test::query_accessor query{ store };
BOOST_REQUIRE(!store.create(test::events_handler));
BOOST_REQUIRE(query.initialize(test::genesis));
BOOST_REQUIRE(query.set(test::block1a, context{ 0, 1, 0 }, false, false));
BOOST_REQUIRE(query.set_strong(1));
BOOST_REQUIRE(query.set(test::block_spend_1a, context{ 0, 2, 0 }, false, false));
BOOST_REQUIRE(query.set_strong(2));

const system::chain::point point
{
test::block1a.transactions_ptr()->front()->hash(false), 0
};

const auto height = query.find_strong_spender_height(point);
BOOST_REQUIRE(!height.is_terminal());
BOOST_REQUIRE_EQUAL(height.value, 2u);
}

BOOST_AUTO_TEST_CASE(query_confirmed__is_confirmed_input__genesis__true)
{
settings settings{};
Expand Down
Loading