Conversation
…orted decentralized coordination.
hokeun
changed the title
hokeun
marked this pull request as ready for review
June 11, 2026 19:41
… prepare git-hosted package fetched from "https://codeload.github.com/lf-lang/reactor-ts/tar.gz/87621f4c5a50b6a0c80cff43a1830938d83b340b": The git-hosted package "@lf-lang/reactor-ts@0.6.2" needs to execute build scripts but is not in the "allowBuilds" allowlist." The root cause is clear: pnpm 10.x changed allowBuilds matching — for git-hosted packages it now requires the full resolved URL (with commit hash), not just the package name. Since the hash is only known after pnpm downloads the package, the static pnpm-workspace.yaml template can't pre-authorize it by name alone. The reliable fix is dangerouslyAllowAllBuilds: true. Despite the name, it's safe here because these are generated, isolated project directories where we explicitly control every installed package — there's no risk of a malicious package sneaking in.
hokeun
commented
Jun 11, 2026
…ifically 10.0–10.1) only matches git-hosted packages against their resolved specifier, i.e., the codeload URL with the specific commit hash (@lf-lang/reactor-ts@https://codeload.github.com/.../tar.gz/<sha>). The package name alone doesn't match. Since the hash is only known after pnpm fetches the package, we can never put the correct key in a static template file. Why dangerouslyAllowAllBuilds: true works: This is a first-class pnpm 10 setting (defined in pnpm's config schema as dangerouslyAllowAllBuilds?: boolean) that bypasses the allowBuilds check entirely. It's safe to use here because these are generated, isolated project directories, every installed package is explicitly listed in a package.json we control, so there's no risk of a malicious package sneaking in.
Jakio815
reviewed
Jun 11, 2026
edwardalee
approved these changes
Jun 12, 2026
edwardalee
left a comment
edwardalee
left a comment
Collaborator
There was a problem hiding this comment.
Looks OK to me. The dangerouslyAllowAllBuilds setting makes me nervous, but the explanation sounds reasonable.
Member
Author
Thank you! Using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: Currently,
lfccompiles a TypeScript LF program with decentralized coordination in the target config without any error, even though decentralized coordination is not supported for TypeScript. Federated execution is supported with TypeScript, but only with centralized coordination.