pkg/pillar: bump eve-libs to pick up SFTP scheme-qualified host fix - #6294
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6294 +/- ##
==========================================
+ Coverage 24.31% 24.66% +0.35%
==========================================
Files 512 522 +10
Lines 93853 95569 +1716
==========================================
+ Hits 22817 23570 +753
- Misses 69221 70002 +781
- Partials 1815 1997 +182 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
christoph-zededa
approved these changes
Aug 10, 2026
Update eve-libs to include lf-edge/eve-libs#90, which fixes the SFTP datastore's getSftpClient to accept a scheme-qualified host (sftp://host:port) as well as the bare host:port form. Since EVE requires datastore Fqdn to always be scheme-qualified, SFTP downloads were failing with a DNS lookup on the literal "sftp" scheme instead of the real hostname. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Milan Lenco <milan@zededa.com>
milan-zededa
force-pushed
the
upgrade-eve-libs
branch
from
August 14, 2026 08:49
82f8fd2 to
47a324e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bump the
pkg/pillareve-libs dependency to includelf-edge/eve-libs#90 (and update the vendor folder accordingly via
go mod tidy && go mod vendor).That fix makes
getSftpClientaccept a scheme-qualified host(
sftp://host:port) in addition to the barehost:portform. Since#5588, EVE's datastore
Fqdnis always scheme-qualified for everydatastore type, including SFTP, which broke
getSftpClient's naivestrings.Split(host, ":")assumption: the first element became theliteral scheme
sftpinstead of the real host, so SFTP downloadsfailed with:
PR dependencies
None.
How to test and validate this PR
sftp://<host>:<port>) and an imagethat downloads from it.
lookup error on the literal
sftpscheme (see log snippet above).real host.
Covered by evetest
TestSFTPDatastore.Changelog notes
Fixed SFTP datastore downloads, which were failing because the
scheme-qualified datastore URL was being misparsed as the hostname.
PR Backports
Checklist