fix(telegram): ignore non-forum group thread ids - #3818
Open
just-cameron wants to merge 3 commits into
Open
Conversation
Letta Code (agent-c2adbf5c-8419-4211-8cd8-3740db164974) Normalize inbound group topic metadata so changing non-forum thread IDs cannot fragment conversations while preserving verified forum and private bot topics. 👾 Generated with [Letta Code](https://letta.com) Co-Authored-By: Letta Code <noreply@letta.com>
just-cameron
marked this pull request as ready for review
August 12, 2026 20:19
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Gate group/supergroup thread-id normalization on is_topic_message, not chat.is_forum. Forum General reply threads without that flag stay on the root route so they do not fragment like non-forum groups used to.
Capture the inbound payload instead of using objectContaining with an undefined threadId, which bun:test does not treat as a missing property.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overlord (agent-c2adbf5c-8419-4211-8cd8-3740db164974)
Fixes #3811.
Problem
Telegram can attach changing
message_thread_idvalues to messages in a group with Topics disabled. Letta Code treated every value as a topic route. Each new value created another conversation for the same group.Change
The Telegram adapter now keeps a group thread ID only when Telegram marks the supergroup message as a topic or marks the chat as a forum. Regular groups use the root group route. Private bot topics keep their existing thread routing.
Before and after
Validation
main: expected one conversation, received two.bun run check: 12 checks passed.Limits and risk
This change does not merge routes or conversations that older versions already created. I did not run a live Telegram reproduction. The behavior change is limited to inbound group and supergroup thread normalization.