Skip to content

fix: update packageManager to [email protected] to match lockfileVersion 9.0 in pnpm-lock.yaml#4432

Merged
matthew-dean merged 3 commits into
masterfrom
copilot/release-not-created-again
Mar 24, 2026
Merged

fix: update packageManager to [email protected] to match lockfileVersion 9.0 in pnpm-lock.yaml#4432
matthew-dean merged 3 commits into
masterfrom
copilot/release-not-created-again

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 19, 2026

Every create-release-pr workflow run was silently failing at pnpm install --frozen-lockfile — never reaching the PR creation step — because packageManager: "[email protected]" in package.json was incompatible with the lockfileVersion: '9.0' in pnpm-lock.yaml. pnpm 8 ignores lockfile v9 entirely, then --frozen-lockfile aborts with ERR_PNPM_NO_LOCKFILE. This mismatch was introduced by PR #4426 (make-dir upgrade), which regenerated the lockfile with pnpm 9 but didn't update packageManager.

Changes

  • package.json — bump packageManager from [email protected][email protected]. All three workflow files use pnpm/action-setup@v4 without a pinned version, so they pick this up automatically.

  • scripts/test-release-automation.js — add Section 7: a regression test that cross-checks the pnpm major version in packageManager against lockfileVersion in pnpm-lock.yaml. Fails loudly if they're incompatible (e.g. lockfile v9 + pnpm 8), so this can't silently recur.

  • .github/workflows/create-release-pr.yml — remove the paths: ['packages/**'] trigger filter so the workflow fires on any push to master/alpha, not only commits touching package source files.


🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

Copilot AI changed the title [WIP] Fix missing release PR for recent merges fix: trigger create-release-pr on any push to master/alpha Mar 19, 2026
Copilot AI requested a review from matthew-dean March 19, 2026 22:54
Copilot AI changed the title fix: trigger create-release-pr on any push to master/alpha fix: update packageManager to [email protected] to match lockfileVersion 9.0 in pnpm-lock.yaml Mar 19, 2026
@matthew-dean matthew-dean marked this pull request as ready for review March 20, 2026 20:29
@dosubot dosubot Bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Mar 20, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 20, 2026

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 340c3c58-796a-4b11-823d-fb6654a22bbb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch copilot/release-not-created-again

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can enforce grammar and style rules using `languagetool`.

Configure the reviews.tools.languagetool setting to enable/disable rules and categories. Refer to the LanguageTool Community to learn more.

@matthew-dean matthew-dean merged commit 060fd7f into master Mar 24, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants