Exposed Line Color, Line Gradient Start Color, Line Gradient End Color as props. - #61
Open
m3rlin94 wants to merge 21 commits into
Open
Exposed Line Color, Line Gradient Start Color, Line Gradient End Color as props. #61m3rlin94 wants to merge 21 commits into
m3rlin94 wants to merge 21 commits into
Conversation
Added how to pass the props for, 1. line color 2. starting gradient line color 2. ending gradient line color
Added functions to retrieve values from react props. The functions are as follows. 1. setLineColor to retrieve the line color without gradient 2. lineGradientColorFrom to retrieve starting gradient color 3. setLineGradientColorTo to retrieve ending gradient color
Three methods were added to get the values which were passed from props and assigned them to the Paint object. The new methods are as follows, 1. setLineColor 2. setLineGradientColorFrom 3. setLineGradientColorTo
Added new PropTypes for lineColor, lineGradientColorFrom, and lineGradientColorTo props.
|
@lesliesam Thank you for this awesome library. It's much better than any other picker library for react-native. It would be very helpful for the community if you could please merge this PR. |
|
@lesliesam can you merge this PR? |
|
Has this been merged? Still doesn't work on iOS or Android? @lesliesam @6axter82 @m3rlin94 |
|
@He1nr1chK I am using react-native-wheel-picker-android the last maintenance is about 6 month ago and I had no any issue with using it: https://github.com/KalonTech/ReactNativeWheelPicker |
|
Hi @6axter82 appreciate the comment. Thank you will try it. |
maherzaidoune
approved these changes
May 18, 2020
tvc97
added a commit
to tvc97/react-native-wheel-picker
that referenced
this pull request
May 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This can be used on android at the moment.