Skip to content

test(render-foundation): data-URI SVG 解码验证 - #143

Merged
leizongmin merged 2 commits into
mainfrom
bing-t5-paint-bg-image
Oct 12, 2026
Merged

leizongmin merged 2 commits into
mainfrom
bing-t5-paint-bg-image

Conversation

@leizongmin

@leizongmin leizongmin commented Oct 12, 2026 •

Copy link
Copy Markdown
Owner

Note

High Risk
Removing BudgetedRenderSession::new in page-load budget rendering can panic at runtime; the dispatch-by-magic test may no longer execute.

Overview
Adds a render-foundation unit test that decodes a URL-encoded data:image/svg+xml… URI via decode_data_uri and checks the SVG rasterizes to a non-zero bitmap (bing-t5 / CSS background-image data-URI path).

The existing magic-byte dispatch test is renamed to test_decode_image_bytes_dispatches_by_magic and is no longer marked #[test], so it may stop running; the new SVG data-URI test has a duplicate #[test] attribute.

In webview advance_render, the line that created BudgetedRenderSession::new(html, css_for_render) after substitute_css_vars_text was removed, while the code still expects a session—likely an accidental regression unless session creation moved elsewhere.

Reviewed by Cursor Bugbot for commit 3ed4223. Bugbot is set up for automated code reviews on this repo. Configure here.

@cursor

cursor Bot commented Oct 12, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: a4ab85d1-89a5-407c-b898-95156f6e7038)

@leizongmin
leizongmin merged commit fa39ce8 into main Oct 12, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant