Skip to content

fix(engine): data-URI background-image 不再跳过——SVG 图标/壁纸走 fetch+cache(C4 根因) - #141

Merged
leizongmin merged 1 commit into
mainfrom
bing-t5-paint-bg
Oct 11, 2026
Merged

leizongmin merged 1 commit into
mainfrom
bing-t5-paint-bg

Conversation

@leizongmin

@leizongmin leizongmin commented Oct 11, 2026 •

Copy link
Copy Markdown
Owner

Note

Low Risk
Visibility-only API change with no logic edits; risk is limited to new internal callers if added elsewhere in the crate.

Overview
This PR makes a single visibility change: collect_custom_props in async_load.rs is now pub(crate) instead of module-private.

Behavior of the scanner is unchanged—it still walks CSS text, collects --custom-property: value pairs inside rule blocks, and feeds the existing substitute_css_vars_text path before budgeted render. The change only allows other code in the webview crate to reuse that collector without duplicating the parser (aligned with the bing-t5 C3/C4 work around CSS custom properties and var() substitution).

There are no call-site updates in this diff; runtime behavior should be identical unless another crate module starts calling the function in the same branch.

Reviewed by Cursor Bugbot for commit 0620e81. Bugbot is set up for automated code reviews on this repo. Configure here.

@cursor

cursor Bot commented Oct 11, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: d232fc72-5496-438f-adb6-6c407af4ce15)

@leizongmin
leizongmin merged commit ecaa0ad into main Oct 11, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant