Skip to content

Update identification script - #107

Merged
amacati merged 3 commits into
mainfrom
fix.identification
Sep 8, 2026
Merged

amacati merged 3 commits into
mainfrom
fix.identification

Conversation

@ratheron

@ratheron ratheron commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

The identification script has two issues:

  1. The rotation plotting fails when there is no validation data provides and the translation plotting return a side by side plot with one empty. This PR checks if there is validation data and adjusts the plots
  2. Since in an earlier version, we didn't expose the Euler dynamics, we had to transform the state. This slowed the fit significantly. However, since the Euler dynamics are exposed now, we can use them to get a 5x speedup.

@ratheron
ratheron requested a review from amacati as a code owner September 8, 2026 11:30

@amacati amacati left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Comment thread crazyflow/dynamics/utils/identification.py Outdated
@amacati
amacati merged commit 3980e2b into main Sep 8, 2026
6 checks passed
@amacati
amacati deleted the fix.identification branch September 8, 2026 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants