Repository navigation
Conversation
8 tasks
rtibbles
requested changes
Aug 22, 2025
rtibbles
left a comment
rtibbles
left a comment
Member
There was a problem hiding this comment.
Everything is looking good, except that the Back to Home button is not functional.
| :text="$tr('refreshAction')" | ||
| @click="reloadPage" | ||
| /> | ||
| <KButton |
Member
There was a problem hiding this comment.
To maintain the link-type behaviour here, this needs to be a KRouterLink instead of a KButton, with the backHomeLink object using v-bind instead:
```suggestion
<KRouterLink
v-bind="backHomeLink"
appearance="raised-button"
:text="$tr('backToHomeAction')"
/>
Alternatively, if that doesn't play nicely with KButtonGroup you can bind the @click event of the KButton to trigger programmatic navigation with Vue Router https://v3.router.vuejs.org/guide/essentials/navigation.html
@click="$router.push(backHomeLink)"
in place of the v-bind.
Contributor
Author
There was a problem hiding this comment.
right, ill update it
Member
|
@Kartikayy007 are you still planning to push the requested change? |
MisRob
changed the title
AllanOXDi
pushed a commit
to AllanOXDi/studio
that referenced
this pull request
Nov 20, 2025
…ue (learningequality#5313) * Replace Vuetify (VLayout, VBtn) with KDS components in GenericError.vue * Replace KRouterLink with KButton for back navigation in GenericError.vue * Properly handle back to home. --------- Co-authored-by: Richard Tibbles <richard@learningequality.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removed Vuetify dependencies from the
GenericError.vuecomponent by replacing them with Kolibri Design System (KDS) components.Changes Made
AppErrorwithStudioAppError(Vuetify-free version).VLayoutwrapper withKButtonGroupfor semantic button grouping.VBtncomponents with:KButton(Refresh)KRouterLink(Navigation)Manual Verification
ChannelListIndex.vueto force display error page (v-if="true").Screenshots
After (with KDS):
References
Reviewer Guidance
How to Test