Repository navigation
Conversation
bjester
marked this pull request as ready for review
October 23, 2026 19:33
Contributor
🟡 Waiting for changesOutcome: skipped — rebased to Last updated: 2026-10-24 21:56 UTC |
rtibblesbot
reviewed
Oct 23, 2026
rtibblesbot
left a comment
Contributor
There was a problem hiding this comment.
PR #400: no findings.
- The
rmc=removal leaves the generated SQL unchanged. Neither merge-conflict template has an{rmc}placeholder. - Apart from that removal and dropped
u""prefixes, the reformatted files' ASTs are unchanged. ruff checkandruff format --checkpass on the whole tree.
CI is still pending, so this is a COMMENT, not an approval.
Next step: This is a low-risk change; it needs a light-touch code review by a human engineer.
Written by rtibblesbot, an LLM-based coding agent.
bjester
added this pull request to stack #402
October 23, 2026 20:47
Neither query references {rmc}, so ruff flags the keyword as F522.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Formatting and import sorting only, produced by ruff 0.15.16 with the project config. No behavior change: each file's AST is unchanged apart from import order and dropped u"" string prefixes. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The list predates ruff. It came from the flake8 config with no recorded reason, and with ruff it also skipped import sorting and formatting. The migrations pattern matched no files. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
It ran pre-commit, which the project replaced with prek. Run `prek run --all-files` instead. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
bjester
force-pushed
the
reformatting-394
branch
from
October 23, 2026 21:35
d30e996 to
ecf390e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes every entry from
[tool.ruff].exclude. Before, ruff skipped linting, import sorting and formatting for these files, even when a commit changed them.The decision for each excluded path:
morango/*/migrations/*morango/migrations/.docsdocs/conf.py, the only Python file.morango/sync/operations.pymorango/sync/backends/postgres.pymorango/sync/backends/sqlite.pytests/testapp/tests/test_crypto.pyThe PR also removes the
linttarget from theMakefile. The target ranpre-commit, which is no longer a dependency. Runprek run --all-filesinstead.TODO
Reviewer guidance
u""string prefixes, which have no effect in Python 3. No SQL string changed.rmc=keyword argument from two SQL.format()calls. Neither query contains{rmc}..git-blame-ignore-revscontains the full SHA of ca41d10, and a squash or rebase changes that SHA.blame.ignoreRevsFileset,git blameshows the earlier authors for the reformatted files. Two lines still show ca41d10: a blank line insqlite.pyand a closing)intest_crypto.py. The formatter added these lines, so they have no earlier author.Test results:
prek run --all-filespasses.Issues addressed
Closes #394
Documentation
None.
AI usage
I used Claude Code to make the changes, with the evaluation in #394 as the plan. Claude Code measured the effect of each exclude, split the work into separate commits for the code fix and the reformat, and compared the ASTs to show that the reformat changes no behavior. It also ran the test suite on SQLite and PostgreSQL, and drafted this description. I reviewed the changes before I opened the PR.
🤖 Generated with Claude Code