Skip to content

Fixes numeric keypad z-index value - #15282

Open
AlexVelezLl wants to merge 1 commit into
learningequality:developfrom
AlexVelezLl:numeric-keypad-zindex
Open

AlexVelezLl wants to merge 1 commit into
learningequality:developfrom
AlexVelezLl:numeric-keypad-zindex

Conversation

@AlexVelezLl

Copy link
Copy Markdown
Member

Summary

  • Updates the numeric keypad z-index to 10, which follows the KDS z-index guidelines, and it lies on top of the BottomAppBar (z-index: 8, but later in the DOM) and below the Side Panel backdrop (z-index: 11).
  • Checked through different scenarios hunting bugs, but found nothing.
image image image image image

References

Closes #15158.

Reviewer guidance

  • Open an exercise resource with a numeric input.
  • Click on the input.
  • Play with different screen sizes, different scenarios, and check that the position of the NumericKeypad is correct.

AI usage

None.

@github-actions

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Perseus NumericKeypad renders above SidePanelModal (but below KModal) due to non-compliant z-index values

1 participant