Remove the old Resource surface and the _v2 method scaffolding - #15233
rtibblesbot wants to merge 6 commits into
Conversation
npm Package VersionsWarning The following packages have changed files but no version bump:
If these changes affect published code, consider bumping the version. |
Build Artifacts
Smoke test screenshot |
80274fd to
a488f2b
Compare
8363463 to
73b1f0d
Compare
57ad048 to
ca1ff3d
Compare
AlexVelezLl
left a comment
There was a problem hiding this comment.
Hey @rtibblesbot. Could you please rebase on top of develop? Just merged #15234.
Both facility list endpoints set no pagination_class, so list() resolves with the same bare array Collection.data did. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Delete the old client-based implementations; the _v2 bodies keep the bare names. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Delete the fetchModel/fetchCollection overrides along with the old custom methods; the _v2 bodies keep the bare names. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Drop the _v2 suffix across eight resources, deleting the old implementations. NetworkLocationResource's shared updateConnectionStatus and fetchFacilities go with them: the static and dynamic variants had no callers, and staticnetworklocation_facilities_detail was never a registered URL. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Removes the read-through JS cache along with it: the surviving methods coalesce concurrent identical GETs but never serve stale data. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
ca1ff3d to
0c62f4d
Compare
|
Rebased on develop (through #15234). #15234 landed one new Swept the whole tree for the same class rather than just that one call: Full Jest suite: 5885 passed. The one failure, |
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
0c62f4d to
b25e46a
Compare
Summary
Model/Collectionlayer, its read-through JS cache, theforceescape hatch, and the old base methods fromResource._v2custom method to its original name, replacing the old implementation.References
Closes #15068.
Reviewer guidance
KOLIBRI_HOMEand port (not.reviews/self-qa-state): every step advances, the provisioning task completes, and you land signed in on the Device page.StaticNetworkLocationResourceandDynamicNetworkLocationResourceloseupdateConnectionStatusandfetchFacilities: they shared the deleted module-level implementations and had no_v2siblings. No in-tree callers, but an out-of-tree plugin calling them would break.AI usage
Used Claude Code to execute the removal resource by resource, updating each call site and spec alongside the method it renamed. Verified with the full frontend test suite and prek.
@rtibblesbot's comments are generated by an LLM, and should be evaluated accordingly
How was this generated?
Deviations from the issue spec
get/list/creategetwas an old method and it is removed.listandcreateare the new request-based methods — there was never an old pair under those names.🟡 Waiting for feedback
Last updated: 2026-09-14 17:06 UTC