Repository navigation
Refactor sequence-doc toggles to per-configuration evaluation - #671
Open
AntoineGautier wants to merge 1 commit into
Open
AntoineGautier wants to merge 1 commit into
AntoineGautier wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This addresses #666.
Testing
CI tests added for the per-configuration toggle logic:
cd /server/scripts/sequence-doc && pytest -c pytest.toml -k test_toggles.pyAll golden tests pass on client and server.
End-to-end tests have also been performed by creating the SOO document with the following system options.
AHU
Cooling-only box
✅ The feature branch produces the same document as the main branch.