Skip to content
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/icons/FilledCircleIcon.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,12 @@ export const FilledCircleIcon: FC<IconProps> = ({
...props
}) => {
return (
<svg width={width} height={height} xmlns="http://www.w3.org/2000/svg" viewBox="0 0 40 40">
<svg width={width} height={height} xmlns="http://www.w3.org/2000/svg" viewBox="0 0 40 40" {...props}>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kishore08-07 revert this

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saurabhraghuvanshii Aligned with the existing repo convention, placing {...props} directly on the ensures consistency across all icons.

<path
fillRule="evenodd"
clipRule="evenodd"
d="M11.3661 38.0349C1.40555 33.2661 -2.80363 21.3246 1.96473 11.3628C4.25461 6.57899 8.35082 2.90088 13.3523 1.13757C18.3537 -0.62574 23.8507 -0.329761 28.6338 1.96035C38.5946 6.72929 42.8037 18.6709 38.0351 28.6325C33.2669 38.5944 21.3267 42.804 11.3661 38.0349Z"
fill={fill}
{...props}
/>
</svg>
);
Expand Down
6 changes: 3 additions & 3 deletions src/icons/Response/Responseicon.tsx
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
import { DEFAULT_HEIGHT, DEFAULT_WIDTH } from '../../constants/constants';
import { DARK_PRIMARY_COLOR } from '../../theme';
import { IconProps } from '../types';
import { CustomIconProps } from '../types';

export const ResponseIcon = ({
width = DEFAULT_WIDTH,
height = DEFAULT_HEIGHT,
primaryFill = DARK_PRIMARY_COLOR,
...props
}: IconProps): JSX.Element => {
}: CustomIconProps): JSX.Element => {
return (
<svg
xmlns="http://www.w3.org/2000/svg"
Expand Down Expand Up @@ -79,4 +79,4 @@ export const ResponseIcon = ({
);
};

// export default FilterIcon;
export default ResponseIcon;
Copy link
Copy Markdown
Member

@saurabhraghuvanshii saurabhraghuvanshii Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kishore08-07 this is not needed, because you already exporting from index.ts

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saurabhraghuvanshii The export default in each icon component (e.g., Responseicon.tsx) is required because the index file uses export { default as ... } from './..'. Removing the default export would break the chain. This is the standard pattern used for all icons in the repo.

2 changes: 1 addition & 1 deletion src/icons/Response/index.ts
Comment thread
kishore08-07 marked this conversation as resolved.
Original file line number Diff line number Diff line change
@@ -1 +1 @@
export { default as ResponseIcon } from './responseicon';
export { default as ResponseIcon } from './Responseicon';
76 changes: 44 additions & 32 deletions src/icons/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,27 @@ export * from './AccessTime';
export * from './AccessTimeFilled';
export * from './Add';
export * from './AddCircle';
export * from './Alert';
export * from './Application';
export * from './ArrowBack';
export * from './ArrowCompress';
export * from './ArrowDropDown';
export * from './ArrowExpand';
export *from './Article';
export * from './Article';
export * from './Bell';
export * from './Bus';
export * from './Calculate';
export * from './Calender';
export * from './CaretDown';
export * from './CatalogIcon';
export * from './Chain';
export * from './Challenges';
export * from './Chat';
export * from './Check';
export * from './CheckCircle';
export * from './CheckCircleOutline';
export * from './Chevron';
export * from './ChevronLeft';
export * from './Circle';
export * from './Clone';
export * from './Close';
Expand All @@ -21,60 +33,46 @@ export * from './Column';
export * from './CompareArrows';
export * from './Component';
export * from './Configuration';
export * from './ContentClassIcons';
export * from './ContentFilter';
export * from './Copy';
export * from './CreateNew';
export * from './Credential';
export * from './CrossCircle';
export * from './Dashboard';
export * from './Database';
export * from './DataObject';
export * from './Delete';
export * from './Deploy';
export * from './Deployments';
export * from './Description';
export * from './Design';
export * from './Designer';
export * from './Detail';
export * from './DropDownIcon';
export * from './Error';
export * from './EmojiEvents';
export * from './ExpandAll';
export * from './Favorite';
export * from './Filter';
export * from './FolderRounded';
export * from './Fullscreen';
export * from './Hierarchical';
export * from './Info';
export { default as InsertChartIcon } from './InsertChartIcon';
export * from './Rectangle';
export * from './Shapes';
// export { default as MergeActionIcon } from "./MergeActionIcon";
export * from './Mesh';
// export { default as ModifiedApplicationFileIcon } from "./ModifiedApplicationFileIcon";
// export { default as OriginalApplicationFileIcon } from "./OriginalApplicationFileIcon";
export * from './Calculate';
export * from './Calender';
export * from './CaretDown';
export * from './Chain';
export * from './Challenges';
export * from './CheckCircle';
export * from './CheckCircleOutline';
export * from './ChevronLeft';
export * from './ContentClassIcons';
export * from './Database';
export * from './Deployments';
export * from './Design';
export * from './DiscussForum';
export * from './Document';
export * from './Done';
export * from './Download';
export * from './Drag';
export * from './DropDownIcon';
export * from './Edit';
export * from './Ellipsis';
export * from './EmojiEvents';
export * from './EmptyStyle';
export * from './Environment';
export * from './Error';
export * from './ErrorOutline';
export * from './ExpandAll';
export * from './ExpandMore';
export * from './Export';
export * from './ExternalLink';
export * from './ErrorOutline';
export * from './Favorite';
export * from './Feedback';
export * from './File';
export { default as FilledCircleIcon } from './FilledCircleIcon';
export * from './Filter';
export * from './FolderRounded';
export * from './Fullscreen';
export * from './GetApp';
export * from './GetStarted';
export * from './Github';
Expand All @@ -83,9 +81,12 @@ export * from './GridView';
export * from './Group';
export * from './GroupAdd';
export * from './HelpIcon';
export * from './Hierarchical';
export * from './Idea';
export * from './IndeterminateCheckBox';
export * from './Info';
export * from './InfoOutlined';
export { default as InsertChartIcon } from './InsertChartIcon';
export * from './InviteUser';
export * from './Kanvas';
export * from './Kubernetes';
Expand All @@ -94,17 +95,23 @@ export * from './Learning';
export * from './LeftAngledArrow';
export * from './LeftArrow';
export * from './Lock';
export * from './LockClockOutlinedIcon';
export * from './Logout';
export * from './Mendeley';
export * from './Menu';
// export { default as MergeActionIcon } from './MergeActionIcon';
export * from './Mesh';
export * from './Meshery';
export * from './MesheryFilter';
export * from './MesheryOperator';
// export { default as ModifiedApplicationFileIcon } from './ModifiedApplicationFileIcon';
export * from './MoreVert';
export * from './MoveFile';
export * from './Open';
export * from './OpenInNew';
export * from './Organization';
// export { default as OriginalApplicationFileIcon } from './OriginalApplicationFileIcon';
export * from './PanelDragHandle';
export * from './PanTool';
export * from './Pattern';
export * from './People';
Expand All @@ -122,18 +129,21 @@ export * from './Refresh';
export * from './Remove';
export * from './Reset';
export * from './Resize';
export * from './Response';
export * from './RightArrow';
export * from './Ring';
export * from './Save';
export * from './Science';
export * from './Screenshot';
export * from './Search';
export * from './Settings';
export * from './Shapes';
export * from './Share';
export * from './SMP';
export * from './SocialMedial';
export * from './Star';
export * from './Success';
export * from './SwapVert';
export * from './TableView';
export * from './TachographDigital';
export * from './Tachometer';
Expand All @@ -154,4 +164,6 @@ export * from './View';
export * from './Visibility';
export * from './Visualizer';
export * from './Warning';
export * from './Workspace';
export * from './Wasm';
export * from './Workspace';
export * from './Zoom';