-
Notifications
You must be signed in to change notification settings - Fork 166
fix(seo): resolve crawlable links and aria-labels #933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Daniel-1600
wants to merge
4
commits into
layer5io:master
Choose a base branch
from
Daniel-1600:fix-seo-issues
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
5ea4d48
fix(seo): resolve crawlable links and aria-labels
Daniel-1600 8aa8ac9
fix: add aria-labels to navbar icon links and fix crawlable anchor
Daniel-1600 8e5637a
Merge branch 'master' into fix-seo-issues
CodexRaunak 5f3b6a2
Merge branch 'master' into fix-seo-issues
saurabhraghuvanshii File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,14 +4,14 @@ | |
| <!-----------------> | ||
| <div class="row footer-top"> | ||
| <div class="col-lg-6"> | ||
| <a href="/"> | ||
| <a href="/" aria-label="Home"> | ||
| {{ $svg := resources.Get "icons/logo.svg" }} | ||
| <img class="footer-logo" src="{{ $svg.Permalink }}" alt="Footer Logo Layer5" data-modal="false"> | ||
| </a> | ||
| </div> | ||
| <div class="col-lg-6 footer-info footer-icons"> | ||
| {{ range .Site.Params.links.footer.icons }} | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. good. ✅ |
||
| <a href="{{ .url }}" class="{{ .class }}" target="_blank" rel="noreferrer"> | ||
| <a href="{{ .url }}" class="{{ .class }}" target="_blank" rel="noreferrer" aria-label="{{ .alt }}"> | ||
| {{ $svg1 := resources.Get .icon }} | ||
| <img height="30px" src="{{ $svg1.Permalink }}" alt="{{ .alt }}" data-modal="false"> | ||
| </a> | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uh-oh... are we still saying "Twitter", not "X"? Hopefully, we are using the X logo, not the Twitter logo.
Please verify/change, @Daniel-1600. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on it